From 3b14e7c1faa99cd0b04b905684e5866c3a7cb5e9 Mon Sep 17 00:00:00 2001 From: Nazar Gargol Date: Mon, 13 Jan 2020 18:49:25 +0700 Subject: [PATCH] Removed redundant empty string handling logic in users module no issue - Since the Member model started to be used the logic handling empty strings -> null conversion is now handled in the core here https://github.com/TryGhost/Ghost/blob/8fd1e81/core/server/models/base/index.js#L492-L499 --- ghost/members-api/lib/users.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ghost/members-api/lib/users.js b/ghost/members-api/lib/users.js index f5856b5229..65a39b7673 100644 --- a/ghost/members-api/lib/users.js +++ b/ghost/members-api/lib/users.js @@ -5,8 +5,8 @@ let Member; async function createMember({email, name, note}, options = {}) { const model = await Member.add({ email, - name: name || null, - note: note || null + name, + note }); const member = model.toJSON(options); return member; @@ -26,8 +26,8 @@ async function getMember(data, options = {}) { async function updateMember({name, note, subscribed}, options = {}) { const attrs = { - name: name || null, - note: note || null + name, + note }; if (subscribed !== undefined) {