From 3a97d39d72758dc6c8434e166f92c1e1b3e5af29 Mon Sep 17 00:00:00 2001
From: Nazar Gargol <nazargargol@gmail.com>
Date: Wed, 8 Jul 2020 19:39:37 +1200
Subject: [PATCH] Substituted csv-parser with papaparse as CSV parsing package

refs https://github.com/TryGhost/Members/commit/5c46786ebc0abf14a64aef482455f504a1cd6e55

- This is continuation of work removing csv-parser as main CSV handling library with more suitable papaparse library
- Referenced commit introduced papaparse as a library to serialize JSON to CSV, this changeset takes it a step further and replaces CSV to JSON seriazliation logic
---
 ghost/members-csv/lib/parse.js       |  6 ++++--
 ghost/members-csv/package.json       |  1 -
 ghost/members-csv/test/parse.test.js | 13 ++++++++++++-
 3 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/ghost/members-csv/lib/parse.js b/ghost/members-csv/lib/parse.js
index 1712678252..1f25051bf5 100644
--- a/ghost/members-csv/lib/parse.js
+++ b/ghost/members-csv/lib/parse.js
@@ -1,5 +1,5 @@
 const Promise = require('bluebird');
-const csvParser = require('csv-parser');
+const papaparse = require('papaparse');
 const _ = require('lodash');
 const fs = require('fs-extra');
 
@@ -63,7 +63,9 @@ const readCSV = ({path, columnsToExtract, mapping}) => {
         readFile.on('err', function (err) {
             reject(err);
         })
-            .pipe(csvParser())
+            .pipe(papaparse.parse(papaparse.NODE_STREAM_INPUT, {
+                header: true
+            }))
             .on('data', function (row) {
                 rows.push(row);
             })
diff --git a/ghost/members-csv/package.json b/ghost/members-csv/package.json
index c3ad71275a..82a36544b9 100644
--- a/ghost/members-csv/package.json
+++ b/ghost/members-csv/package.json
@@ -24,7 +24,6 @@
     "sinon": "9.0.2"
   },
   "dependencies": {
-    "csv-parser": "2.3.3",
     "papaparse": "5.2.0"
   }
 }
diff --git a/ghost/members-csv/test/parse.test.js b/ghost/members-csv/test/parse.test.js
index 13c11dcefd..03b4405861 100644
--- a/ghost/members-csv/test/parse.test.js
+++ b/ghost/members-csv/test/parse.test.js
@@ -3,7 +3,17 @@ const path = require('path');
 const {readCSV} = require('../lib/parse');
 const csvPath = path.join(__dirname, '/fixtures/');
 
-describe('read csv', function () {
+describe('parse', function () {
+    it('read csv: empty file', async function () {
+        const result = await readCSV({
+            path: csvPath + 'empty.csv',
+            columnsToExtract: [{name: 'email', lookup: /email/i}]
+        });
+
+        should.exist(result);
+        result.length.should.eql(0);
+    });
+
     it('read csv: one column', async function () {
         const result = await readCSV({
             path: csvPath + 'single-column-with-header.csv',
@@ -85,6 +95,7 @@ describe('read csv', function () {
         result[1].nombre.should.eql('test');
         result[1].id.should.eql('2');
     });
+
     it('read csv: two columns with empty mapping', async function () {
         const result = await readCSV({
             path: csvPath + 'two-columns-mapping-header.csv',