Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity

Ghost Logo navigation responds correctly to mobile

Browse source 
closes #3522
- Previously, the logo had a href attribute which was manually kept
from executing on mobile. Slow mobile devices that didn’t fully load
the JS would therefore navigate “desktop style”
- The href attribute is now set after the event handler has been loaded, ensuring correct navigation behaviour.
This commit is contained in:
Felix Rieseberg 2014-08-04 17:21:07 -07:00
parent d4626ede74
commit 39c3127bac
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/admin/templates/-navbar.hbs
View file

@ -1,5 +1,5 @@
<header id="global-header" class="navbar"> <header id="global-header" class="navbar">
<a class="ghost-logo" {{bind-attr href=ghostPaths.blogRoot title=ghostPaths.blogRoot}} data-off-canvas="left"> <a class="ghost-logo" data-off-canvas="left">
<span class="hidden">Ghost</span> <span class="hidden">Ghost</span>
</a> </a>
<nav id="global-nav" role="navigation"> <nav id="global-nav" role="navigation">

1
ghost/admin/views/application.js
View file

@ -10,6 +10,7 @@ var ApplicationView = Ember.View.extend({
body.toggleClass('off-canvas'); body.toggleClass('off-canvas');
}); });
}); });
$('[data-off-canvas]').attr('href', this.get('controller.ghostPaths.blogRoot'));
// #### Navigating within the sidebar closes it. // #### Navigating within the sidebar closes it.
$('.js-close-sidebar').on('click', function () { $('.js-close-sidebar').on('click', function () {
body.removeClass('off-canvas'); body.removeClass('off-canvas');