Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity

Upgrade express-hbs, and switch to using registerPartial

Browse source 
fixes #1964, fixes #1975

 - Issues with partial handling which caused #1964  have been part fixed by handlebars, part worked around by express-hbs, we must use `registerPartials` to ensure partials are handled correctly.
 - Issue with error handling which caused #1975 has also been fixed in express-hbs, which now catches the error from handlebars and passes it to express so that we can handle the error with an error page.
This commit is contained in:
Hannah Wolfe 2014-01-23 16:22:25 +00:00
parent cccc19842e
commit 3961b7173f
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
core/server/helpers/template.js
View file

@ -17,8 +17,7 @@ templates.execute = function (name, context) {
// If the partial view is not compiled, it compiles and saves in handlebars
if (typeof partial === 'string') {
partial = hbs.handlebars.compile(partial);
hbs.handlebars.partials[name] = partial;
hbs.registerPartial(partial);
}
return new hbs.handlebars.SafeString(partial(context));

2
package.json
View file

@ -39,7 +39,7 @@
"connect-slashes": "1.2.0",
"downsize": "0.0.4",
"express": "3.4.6",
"express-hbs": "0.5.2",
"express-hbs": "0.7.6",
"fs-extra": "0.8.1",
"knex": "0.5.0",
"moment": "2.4.0",