Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity

🐛 Fixed stripe connect modal not closing

Browse source 
closes https://github.com/TryGhost/Ghost/issues/13090

The `X` on stripe connect modal is not closing the popup as the updated modal changes was not wiring the close method.

Note: Clicking outside the popup to close it was still working
This commit is contained in:
Rishabh 2021-06-24 14:12:32 +05:30
parent 4665e64103
commit 38a499a531
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ghost/admin/app/components/modal-stripe-connect.hbs
View file

@ -1,7 +1,7 @@
<header class="modal-header" data-test-modal="webhook-form" {{will-destroy this.reset}}> <header class="modal-header" data-test-modal="webhook-form" {{will-destroy this.reset}}>
<h1 data-test-text="title">Connect with Stripe</h1> <h1 data-test-text="title">Connect with Stripe</h1>
</header> </header>
<button class="close" href title="Close" {{action "confirm"}} {{action (optional this.noop) on="mouseDown"}}> <button class="close" href title="Close" {{action "closeModal"}} {{action (optional this.noop) on="mouseDown"}}>
{{svg-jar "close"}} {{svg-jar "close"}}
</button> </button>
@ -26,4 +26,4 @@
<span>OK</span> <span>OK</span>
</button> </button>
{{/if}} {{/if}}
</div> </div>

4
ghost/admin/app/components/modal-stripe-connect.js
View file

@ -51,6 +51,10 @@ export default class ModalStripeConnect extends ModalBase {
return this.confirmAction(); return this.confirmAction();
} }
// noop - enter key shouldn't do anything // noop - enter key shouldn't do anything
},
// needed because ModalBase uses .send() for keyboard events
closeModal() {
this.close();
} }
} }
} }