Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
Code Issues Activity

Fixed lint warnings from Admin feature-test

Browse source 
no issue

- converted use of promises to async/await
- removed return from async test functions to clear lint warnings
This commit is contained in:
Kevin Ansfield 2024-09-03 10:53:15 +01:00
parent fd926193ce
commit 3744caa950
1 changed files with 83 additions and 99 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

52
ghost/admin/tests/integration/services/feature-test.js
View file

@ -101,11 +101,10 @@ describe('Integration: Service: feature', function () {
let service = this.owner.lookup('service:feature');
return service.fetch().then(() => {
await service.fetch();
expect(service.get('testFlag')).to.be.true;
expect(service.get('testUserFlag')).to.be.true;
});
});
it('returns false for set flag with config false and labs false', async function () {
stubSettings(server, {testFlag: false});
@ -119,11 +118,10 @@ describe('Integration: Service: feature', function () {
let service = this.owner.lookup('service:feature');
service.config.testFlag = false;
return service.fetch().then(() => {
await service.fetch();
expect(service.get('labs.testFlag')).to.be.false;
expect(service.get('testFlag')).to.be.false;
});
});
it('returns true for set flag with config true and labs false', async function () {
stubSettings(server, {testFlag: false});
@ -137,11 +135,10 @@ describe('Integration: Service: feature', function () {
let service = this.owner.lookup('service:feature');
service.config.testFlag = true;
return service.fetch().then(() => {
await service.fetch();
expect(service.get('labs.testFlag')).to.be.false;
expect(service.get('testFlag')).to.be.true;
});
});
it('returns true for set flag with config is an object and labs true', async function () {
stubSettings(server, {testFlag: true});
@ -155,11 +152,10 @@ describe('Integration: Service: feature', function () {
let service = this.owner.lookup('service:feature');
service.config.testFlag = {key: 'value'};
return service.fetch().then(() => {
await service.fetch();
expect(service.get('labs.testFlag')).to.be.true;
expect(service.get('testFlag')).to.be.true;
});
});
it('returns true for set flag with config true and labs true', async function () {
stubSettings(server, {testFlag: true});
@ -173,11 +169,10 @@ describe('Integration: Service: feature', function () {
let service = this.owner.lookup('service:feature');
service.config.testFlag = true;
return service.fetch().then(() => {
await service.fetch();
expect(service.get('labs.testFlag')).to.be.true;
expect(service.get('testFlag')).to.be.true;
});
});
it('returns false for set flag with accessibility false', async function () {
stubSettings(server, {});
@ -190,11 +185,10 @@ describe('Integration: Service: feature', function () {
let service = this.owner.lookup('service:feature');
return service.fetch().then(() => {
await service.fetch();
expect(service.get('accessibility.testUserFlag')).to.be.false;
expect(service.get('testUserFlag')).to.be.false;
});
});
it('returns true for set flag with accessibility true', async function () {
stubSettings(server, {});
@ -207,11 +201,10 @@ describe('Integration: Service: feature', function () {
let service = this.owner.lookup('service:feature');
return service.fetch().then(() => {
await service.fetch();
expect(service.get('accessibility.testUserFlag')).to.be.true;
expect(service.get('testUserFlag')).to.be.true;
});
});
it('saves labs setting correctly', async function () {
stubSettings(server, {testFlag: false});
@ -225,19 +218,18 @@ describe('Integration: Service: feature', function () {
let service = this.owner.lookup('service:feature');
service.config.testFlag = {key: 'value'};
return service.fetch().then(() => {
await service.fetch();
expect(service.get('testFlag')).to.be.false;
run(() => {
service.set('testFlag', true);
});
return settled().then(() => {
await settled();
expect(server.handlers[2].numberOfCalls).to.equal(1);
expect(service.get('testFlag')).to.be.true;
});
});
});
it('saves accessibility setting correctly', async function () {
stubSettings(server, {});
@ -250,19 +242,17 @@ describe('Integration: Service: feature', function () {
let service = this.owner.lookup('service:feature');
return service.fetch().then(() => {
await service.fetch();
expect(service.get('testUserFlag')).to.be.false;
run(() => {
service.set('testUserFlag', true);
});
return settled().then(() => {
await settled();
expect(server.handlers[4].numberOfCalls).to.equal(1);
expect(service.get('testUserFlag')).to.be.true;
});
});
});
it('notifies for server errors on labs save', async function () {
stubSettings(server, {testFlag: false}, false);
@ -276,14 +266,14 @@ describe('Integration: Service: feature', function () {
let service = this.owner.lookup('service:feature');
service.config.testFlag = false;
return service.fetch().then(() => {
await service.fetch();
expect(service.get('testFlag')).to.be.false;
run(() => {
service.set('testFlag', true);
});
return settled().then(() => {
await settled();
expect(
server.handlers[2].numberOfCalls,
'PUT call is made'
@ -296,8 +286,6 @@ describe('Integration: Service: feature', function () {
expect(service.get('testFlag')).to.be.false;
});
});
});
it('notifies for server errors on accessibility save', async function () {
stubSettings(server, {});
@ -310,14 +298,14 @@ describe('Integration: Service: feature', function () {
let service = this.owner.lookup('service:feature');
return service.fetch().then(() => {
await service.fetch();
expect(service.get('testUserFlag')).to.be.false;
run(() => {
service.set('testUserFlag', true);
});
return settled().then(() => {
await settled();
expect(
server.handlers[3].numberOfCalls,
'PUT call is made'
@ -330,8 +318,6 @@ describe('Integration: Service: feature', function () {
expect(service.get('testUserFlag')).to.be.false;
});
});
});
it('notifies for validation errors', async function () {
stubSettings(server, {testFlag: false}, true, false);
@ -345,7 +331,7 @@ describe('Integration: Service: feature', function () {
let featureService = this.owner.lookup('service:feature');
featureService.config.testFlag = false;
return featureService.fetch().then(() => {
await featureService.fetch();
expect(featureService.get('testFlag'), 'testFlag before set').to.be.false;
run(() => {
@ -354,13 +340,11 @@ describe('Integration: Service: feature', function () {
}, EmberError, 'threw validation error');
});
return settled().then(() => {
await settled();
// ensure validation is happening before the API is hit
expect(server.handlers[2].numberOfCalls).to.equal(0);
expect(featureService.get('testFlag')).to.be.false;
});
});
});
it('has correct labs flags when accessed before and after settings load', async function () {
stubSettings(server, {testFlag: true});