From 36bb014fc09ced9b292d330604700c7710db4cfb Mon Sep 17 00:00:00 2001 From: Thibaut Patel Date: Tue, 1 Mar 2022 13:07:37 +0100 Subject: [PATCH] Simplified time comparison in last-seen-at-updater no issue - The code had un-needed complexity - Removing the extra complexity led to the same behavior, as validated by the unit tests --- ghost/members-events-service/lib/last-seen-at-updater.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ghost/members-events-service/lib/last-seen-at-updater.js b/ghost/members-events-service/lib/last-seen-at-updater.js index ca3b0dc36b..0231f00145 100644 --- a/ghost/members-events-service/lib/last-seen-at-updater.js +++ b/ghost/members-events-service/lib/last-seen-at-updater.js @@ -40,7 +40,7 @@ class LastSeenAtUpdater { */ async updateLastSeenAt(memberId, memberLastSeenAt, timestamp) { const timezone = this._settingsCacheService.get('timezone'); - if (memberLastSeenAt === null || moment(moment.utc(timestamp).tz(timezone).startOf('day')).isAfter(moment.utc(memberLastSeenAt).tz(timezone).startOf('day'))) { + if (memberLastSeenAt === null || moment(moment.utc(timestamp).tz(timezone).startOf('day')).isAfter(memberLastSeenAt)) { await this._memberModel.update({ last_seen_at: moment.utc(timestamp).format('YYYY-MM-DD HH:mm:ss') }, {