Removed passing of error to active theme

refs:  076ad99593

- as of 076ad99593 we no longer use the error property of the active theme anywhere
- cleaning up and removing this usage reduces the code pathways and makes the init fn a bit clearer

core/frontend/services/theme-engine/active.js

@@ -26,16 +26,16 @@ let currentActiveTheme;
 class ActiveTheme {
     /**
      * @TODO this API needs to be simpler, but for now should work!
+     * @param {object} settings
+     * @param {string} settings.locale - the active locale for i18n
      * @param {object} loadedTheme - the loaded theme object from the theme list
      * @param {object} checkedTheme - the result of gscan.format for the theme we're activating
-     * @param {object} error - bootstrap validates the active theme, we would like to remember this error
      */
-    constructor(settings, loadedTheme, checkedTheme, error) {
+    constructor(settings, loadedTheme, checkedTheme) {
         // Assign some data, mark it all as pseudo-private
         this._name = loadedTheme.name;
         this._path = loadedTheme.path;
         this._mounted = false;
-        this._error = error;
 
         // We get passed in a locale
         this._locale = settings.locale || 'en';
@@ -136,13 +136,14 @@ module.exports = {
      * At this point we trust that the theme has been validated.
      * Any handling for invalid themes should happen before we get here
      *
-     * @TODO this API needs to be simpler, but for now should work!
+     * @param {object} settings
+     * @param {string} settings.locale - the active locale for i18n
      * @param {object} loadedTheme - the loaded theme object from the theme list
      * @param {object} checkedTheme - the result of gscan.format for the theme we're activating
      * @return {ActiveTheme}
      */
-    set(settings, loadedTheme, checkedTheme, error) {
+    set(settings, loadedTheme, checkedTheme) {
-        currentActiveTheme = new ActiveTheme(settings, loadedTheme, checkedTheme, error);
+        currentActiveTheme = new ActiveTheme(settings, loadedTheme, checkedTheme);
         return currentActiveTheme;
     }
 };

core/server/services/themes/index.js

@@ -32,21 +32,16 @@ module.exports = {
                     .check(theme)
                     .then(function validationSuccess(checkedTheme) {
                         if (!validate.canActivate(checkedTheme)) {
-                            const checkError = new errors.ThemeValidationError({
+                            logging.error(new errors.ThemeValidationError({
                                 message: tpl(messages.invalidTheme, {theme: activeThemeName}),
                                 errorDetails: Object.assign(
                                     _.pick(checkedTheme, ['checkedVersion', 'name', 'path', 'version']), {
                                         errors: checkedTheme.results.error
                                     }
                                 )
-                            });
+                            }));
-
-                            logging.error(checkError);
-
-                            bridge.activateTheme(theme, checkedTheme, checkError);
-                        } else {
                             // CASE: inform that the theme has errors, but not fatal (theme still works)
-                            if (checkedTheme.results.error.length) {
+                        } else if (checkedTheme.results.error.length) {
                             logging.warn(new errors.ThemeValidationError({
                                 errorType: 'ThemeWorksButHasErrors',
                                 message: tpl(messages.themeHasErrors, {theme: activeThemeName}),
@@ -59,9 +54,7 @@ module.exports = {
                         }
 
                         debug('Activating theme (method A on boot)', activeThemeName);
-
                         bridge.activateTheme(theme, checkedTheme);
-                        }
                     });
             })
             .catch(function (err) {