Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Fixed comments MockedApi and tests

Browse source 
The Comments API should be serving comments in reverse chronological order
This commit is contained in:
Fabien O'Carroll 2024-02-27 15:04:56 -05:00 • committed by Fabien 'egg' O'Carroll
parent 5fae212416
commit 359c1049c6
3 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
apps/comments-ui/test/e2e/auth-frame.test.ts
View file

@ -99,12 +99,12 @@ test.describe('Auth Frame', async () => {
// Check comment2 is replaced with a hidden message
const secondComment = comments.nth(1);
await expect(secondComment).toHaveText('This comment has been hidden.');
await expect(secondComment).not.toContainText('This is comment 4');
await expect(secondComment).not.toContainText('This is comment 2');
// Check can show it again
await moreButtons.nth(1).click();
await moreButtons.nth(1).getByText('Show comment').click();
await expect(secondComment).toContainText('This is comment 4');
await expect(secondComment).toContainText('This is comment 2');
});
test('has admin options when signed in to Ghost admin and as a member', async ({page}) => {
@ -156,12 +156,12 @@ test.describe('Auth Frame', async () => {
// Check comment2 is replaced with a hidden message
const secondComment = comments.nth(1);
await expect(secondComment).toHaveText('This comment has been hidden.');
await expect(secondComment).not.toContainText('This is comment 4');
await expect(secondComment).not.toContainText('This is comment 2');
// Check can show it again
await moreButtons.nth(1).click();
await moreButtons.nth(1).getByText('Show comment').click();
await expect(secondComment).toContainText('This is comment 4');
await expect(secondComment).toContainText('This is comment 2');
});
});

6
apps/comments-ui/test/e2e/pagination.test.ts
View file

@ -39,12 +39,12 @@ test.describe('Pagination', async () => {
await expect(frame.getByTestId('comment-component')).toHaveCount(5);
// Check only the first 5 comments are visible
await expect(frame.getByText('This is comment 1')).toBeVisible();
await expect(frame.getByText('This is comment 1')).not.toBeVisible();
await expect(frame.getByText('This is comment 2')).toBeVisible();
await expect(frame.getByText('This is comment 3')).toBeVisible();
await expect(frame.getByText('This is comment 4')).toBeVisible();
await expect(frame.getByText('This is comment 5')).toBeVisible();
await expect(frame.getByText('This is comment 6')).not.toBeVisible();
await expect(frame.getByText('This is comment 6')).toBeVisible();
// Click the pagination button
await frame.getByTestId('pagination-component').click();
@ -53,7 +53,7 @@ test.describe('Pagination', async () => {
await expect(frame.getByTestId('comment-component')).toHaveCount(6);
// Check comments 6 is visible
await expect(frame.getByText('This is comment 6')).toBeVisible();
await expect(frame.getByText('This is comment 1')).toBeVisible();
// Check the pagination button is not visible
await expect(frame.getByTestId('pagination-component')).not.toBeVisible();

4
apps/comments-ui/test/utils/MockedApi.ts
View file

@ -62,10 +62,10 @@ export class MockedApi {
const bDate = new Date(b.created_at).getTime();
if (aDate === bDate) {
return a.id > b.id ? 1 : -1;
return a.id > b.id ? -1 : 1;
}
return aDate > bDate ? 1 : -1;
return aDate > bDate ? -1 : 1;
});
let filteredComments = this.comments;