From 34b4421452b133c9e636e1adfa49e964fb2a82a9 Mon Sep 17 00:00:00 2001
From: Naz <nazargargol@gmail.com>
Date: Mon, 15 Aug 2022 15:17:20 +0200
Subject: [PATCH] Moved settings cache to an explicit "in memory" adapter

refs https://github.com/TryGhost/Toolbox/issues/364

- Before introducing an image size caching mechanism we need to make existing caches explicit - makes sure caches are operating in multiple different instances.
- Explicit syntax also allows to pass in different configurations for each cache instance (e.g. use different Redis connections for caches with different purposes)
---
 .../server/adapters/cache/SettingsCacheSyncInMemory.js     | 7 +++++++
 .../core/core/server/services/settings/settings-service.js | 2 +-
 ghost/core/core/shared/config/defaults.json                | 4 +++-
 3 files changed, 11 insertions(+), 2 deletions(-)
 create mode 100644 ghost/core/core/server/adapters/cache/SettingsCacheSyncInMemory.js

diff --git a/ghost/core/core/server/adapters/cache/SettingsCacheSyncInMemory.js b/ghost/core/core/server/adapters/cache/SettingsCacheSyncInMemory.js
new file mode 100644
index 0000000000..9d2a1cfd48
--- /dev/null
+++ b/ghost/core/core/server/adapters/cache/SettingsCacheSyncInMemory.js
@@ -0,0 +1,7 @@
+const Memory = require('./Memory');
+
+class SettingsCacheSyncInMemory extends Memory {
+
+}
+
+module.exports = SettingsCacheSyncInMemory;
diff --git a/ghost/core/core/server/services/settings/settings-service.js b/ghost/core/core/server/services/settings/settings-service.js
index 9e8995510f..a7ab794f8b 100644
--- a/ghost/core/core/server/services/settings/settings-service.js
+++ b/ghost/core/core/server/services/settings/settings-service.js
@@ -67,7 +67,7 @@ module.exports = {
      * Initialize the cache, used in boot and in testing
      */
     async init() {
-        const cacheStore = adapterManager.getAdapter('cache');
+        const cacheStore = adapterManager.getAdapter('cache:settings');
         const settingsCollection = await models.Settings.populateDefaults();
         SettingsCache.init(events, settingsCollection, this.getCalculatedFields(), cacheStore);
     },
diff --git a/ghost/core/core/shared/config/defaults.json b/ghost/core/core/shared/config/defaults.json
index 7b11e98591..06548f44ff 100644
--- a/ghost/core/core/shared/config/defaults.json
+++ b/ghost/core/core/shared/config/defaults.json
@@ -25,7 +25,9 @@
             "active": "Default"
         },
         "cache": {
-            "active": "Memory"
+            "active": "Memory",
+            "settings": "SettingsCacheSyncInMemory",
+            "SettingsCacheSyncInMemory": {}
         }
     },
     "storage": {