Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-04-15 03:01:37 -05:00
Code Issues Activity

Updated data-members-newsletter to use the name of the newsletter (#18072)

Browse source 
refs https://github.com/TryGhost/Product/issues/3860

`data-members-newsletter` implementation was updated to use the `name`
of the newsletter instead of it's `id`
This commit is contained in:
Michael Barrett 2023-09-14 16:02:09 +01:00 • committed by GitHub
parent 82e9aae4cc
commit 32eb4635cf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/portal/src/data-attributes.js
View file

@ -25,7 +25,7 @@ export function formSubmitHandler({event, form, errorEl, siteUrl, submitHandler}
let newsletterInputs = event.target.querySelectorAll('input[type=hidden][data-members-newsletter], input[type=checkbox][data-members-newsletter]:checked, input[type=radio][data-members-newsletter]:checked') || [];
for (let i = 0; i < newsletterInputs.length; ++i) {
newsletters.push({id: newsletterInputs[i].value});
newsletters.push({name: newsletterInputs[i].value});
}
if (form.dataset.membersForm) {

4
apps/portal/src/tests/data-attributes.test.js
View file

@ -244,7 +244,7 @@ describe('Member Data attributes:', () => {
test('includes specified newsletters in request', () => {
const {event, form, errorEl, siteUrl, submitHandler} = getMockData({
newsletterQuerySelectorResult: [{
value: 'some_newsletter'
value: 'Some Newsletter'
}]
});
@ -264,7 +264,7 @@ describe('Member Data attributes:', () => {
refUrl: 'https://example.com/blog/',
time: 1611234567890
}],
newsletters: [{id: 'some_newsletter'}]
newsletters: [{name: 'Some Newsletter'}]
});
expect(window.fetch).toHaveBeenCalledWith('https://portal.localhost/members/api/send-magic-link/', {body: expectedBody, headers: {'Content-Type': 'application/json'}, method: 'POST'});
});