Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Fixed non-reverted rewire of imageSize.getImageSizeFromUrl in tests

Browse source 
no issue

- fixes unexpected behaviour in tests run after the `cached-image-size-from-url_spec.js` unit tests
This commit is contained in:
Kevin Ansfield 2020-06-16 20:58:02 +01:00
parent 86f14c28a1
commit 32dd4574af
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
test/unit/lib/image/cached-image-size-from-url_spec.js
View file

@ -9,6 +9,7 @@ const getCachedImageSizeFromUrl = rewire('../../../../core/server/lib/image/cach
describe('lib/image: image size cache', function () { describe('lib/image: image size cache', function () {
let sizeOfStub; let sizeOfStub;
let cachedImagedSize; let cachedImagedSize;
let revertGetCachedImageSizeFromUrl;
beforeEach(function () { beforeEach(function () {
sizeOfStub = sinon.stub(); sizeOfStub = sinon.stub();
@ -17,6 +18,10 @@ describe('lib/image: image size cache', function () {
afterEach(function () { afterEach(function () {
sinon.restore(); sinon.restore();
getCachedImageSizeFromUrl.__set__('cache', {}); getCachedImageSizeFromUrl.__set__('cache', {});
if (revertGetCachedImageSizeFromUrl) {
revertGetCachedImageSizeFromUrl();
}
}); });
it('should read from cache, if dimensions for image are fetched already', function (done) { it('should read from cache, if dimensions for image are fetched already', function (done) {
@ -30,7 +35,7 @@ describe('lib/image: image size cache', function () {
type: 'jpg' type: 'jpg'
})); }));
getCachedImageSizeFromUrl.__set__('imageSize.getImageSizeFromUrl', sizeOfStub); revertGetCachedImageSizeFromUrl = getCachedImageSizeFromUrl.__set__('imageSize.getImageSizeFromUrl', sizeOfStub);
imageSizeSpy = getCachedImageSizeFromUrl.__get__('imageSize.getImageSizeFromUrl'); imageSizeSpy = getCachedImageSizeFromUrl.__get__('imageSize.getImageSizeFromUrl');
@ -69,7 +74,7 @@ describe('lib/image: image size cache', function () {
sizeOfStub.returns(new Promise.reject('error')); sizeOfStub.returns(new Promise.reject('error'));
getCachedImageSizeFromUrl.__set__('imageSize.getImageSizeFromUrl', sizeOfStub); revertGetCachedImageSizeFromUrl = getCachedImageSizeFromUrl.__set__('imageSize.getImageSizeFromUrl', sizeOfStub);
cachedImagedSizeResult = Promise.resolve(getCachedImageSizeFromUrl(url)); cachedImagedSizeResult = Promise.resolve(getCachedImageSizeFromUrl(url));
cachedImagedSizeResult.then(function () { cachedImagedSizeResult.then(function () {