From 32353f292044965bbedb5684deec72e55a9d43ad Mon Sep 17 00:00:00 2001 From: Hannah Wolfe Date: Wed, 23 Nov 2022 15:18:00 +0000 Subject: [PATCH] Removed detail rule from showAPIError refs: https://github.com/TryGhost/Team/issues/1121 - showAPIError is a method intended for formatting errors from the Ghost API - Ghost API Errors do not have a detail field, therefore this code was redundant - there are also no related tests - removing now because I'm trying to cleanup and streamline all our error handling code --- ghost/admin/app/services/notifications.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/ghost/admin/app/services/notifications.js b/ghost/admin/app/services/notifications.js index 80624fcf83..aa2b780c3f 100644 --- a/ghost/admin/app/services/notifications.js +++ b/ghost/admin/app/services/notifications.js @@ -180,8 +180,6 @@ export default class NotificationsService extends Service { msg = GENERIC_ERROR_MESSAGE; } else if (resp instanceof String) { msg = resp; - } else if (!isBlank(resp?.detail)) { - msg = resp.detail; } else if (!isBlank(resp?.message)) { msg = resp.message; }