From 3171df4102306fe2bca816afb963a0b8d01d33f1 Mon Sep 17 00:00:00 2001 From: Daniel Lockyer Date: Tue, 19 Apr 2022 15:53:44 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A5=20Dropped=20support=20for=20Node?= =?UTF-8?q?=2012?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit refs https://github.com/TryGhost/Toolbox/issues/267 - Node 12 becomes EOL on April 30th so we're going to be dropping support for it in Ghost - this commit updates the Node engine ranges so CLI can pick this up, and drops 12.22.1 from the CI matrix --- .github/workflows/test.yml | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 001beaefd5..a516736683 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -100,7 +100,7 @@ jobs: if: github.event_name == 'push' || (github.event_name == 'pull_request' && !startsWith(github.head_ref, 'renovate/')) strategy: matrix: - node: [ '12.22.1', '14.17.0', '16.13.0' ] + node: [ '14.17.0', '16.13.0' ] name: Unit Tests (Node ${{ matrix.node }}) steps: - uses: actions/checkout@v2 @@ -133,7 +133,7 @@ jobs: if: github.event_name == 'push' || (github.event_name == 'pull_request' && !startsWith(github.head_ref, 'renovate/')) strategy: matrix: - node: [ '12.22.1', '14.17.0', '16.13.0' ] + node: [ '14.17.0', '16.13.0' ] env: - DB: sqlite3 NODE_ENV: testing diff --git a/package.json b/package.json index 2fb4d49639..50a788d74e 100644 --- a/package.json +++ b/package.json @@ -51,7 +51,7 @@ "fix": "yarn fix:client && yarn fix:server" }, "engines": { - "node": "^12.22.1 || ^14.17.0 || ^16.13.0", + "node": "^14.17.0 || ^16.13.0", "cli": "^1.17.0" }, "dependencies": {