Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity

Disabled default behavior for modal open keyboard shortcut

Browse source 
refs https://github.com/TryGhost/Team/issues/1665

- disables browser behavior for cmd/ctrl+k for opening search modal
This commit is contained in:
Rishabh 2022-07-06 15:31:51 +02:00
parent fa4adcd365
commit 312ecdbac3
2 changed files with 1 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
ghost/sodo-search/src/App.js
View file

@ -67,6 +67,7 @@ export default class App extends React.Component {
this.setState({
showPopup: true
});
return false;
}
};
document.addEventListener('keydown', this.handleKeyDown);

18
ghost/sodo-search/src/components/PopupModal.js
View file

@ -80,18 +80,6 @@ class PopupContent extends React.Component {
static contextType = AppContext;
componentDidMount() {
// Handle Esc to close popup
if (this.node) {
this.node.focus();
this.keyUphandler = (event) => {
const eventTargetTag = (event.target && event.target.tagName);
if (event.key === 'Escape' && eventTargetTag !== 'INPUT') {
// this.context.onAction('closePopup');
}
};
this.node.ownerDocument.removeEventListener('keyup', this.keyUphandler);
this.node.ownerDocument.addEventListener('keyup', this.keyUphandler);
}
this.sendContainerHeightChangeEvent();
}
@ -103,12 +91,6 @@ class PopupContent extends React.Component {
this.sendContainerHeightChangeEvent();
}
componentWillUnmount() {
if (this.node) {
this.node.ownerDocument.removeEventListener('keyup', this.keyUphandler);
}
}
handlePopupClose(e) {
e.preventDefault();
if (e.target === e.currentTarget) {