Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Fixed the model update method

Browse source 
refs https://github.com/TryGhost/Ghost/pull/14197

- Uses the right method to update a model (`edit`)
- Also fixes the `updateLastSeenAt` comment that wasn't reflecting the code
This commit is contained in:
Thibaut Patel 2022-03-01 17:35:02 +01:00
parent 0ad1e65ff6
commit 30681319b5
2 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ghost/members-events-service/lib/last-seen-at-updater.js
View file

@ -33,10 +33,10 @@ class LastSeenAtUpdater {
}
/**
* Updates the member.last_seen_at field if it wasn't updated in the current UTC day yet
* Example: current time is 2022-02-28 18:00:00 UTC
* - memberLastSeenAt is 2022-02-27 23:00:00 UTC, timestamp is current time, then `last_seen_at` is set to the current time
* - memberLastSeenAt is 2022-02-28 01:00:00 UTC, timestamp is current time, then `last_seen_at` isn't changed
* Updates the member.last_seen_at field if it wasn't updated in the current day yet (in the publication timezone)
* Example: current time is 2022-02-28 18:00:00
* - memberLastSeenAt is 2022-02-27 23:00:00, timestamp is current time, then `last_seen_at` is set to the current time
* - memberLastSeenAt is 2022-02-28 01:00:00, timestamp is current time, then `last_seen_at` isn't changed
* @param {string} memberId The id of the member to be udpated
* @param {string} memberLastSeenAt The previous last_seen_at property value for the current member
* @param {Date} timestamp The event timestamp
@ -44,7 +44,7 @@ class LastSeenAtUpdater {
async updateLastSeenAt(memberId, memberLastSeenAt, timestamp) {
const timezone = this._settingsCacheService.get('timezone');
if (memberLastSeenAt === null || moment(moment.utc(timestamp).tz(timezone).startOf('day')).isAfter(memberLastSeenAt)) {
await this._memberModel.update({
await this._memberModel.edit({
last_seen_at: moment.utc(timestamp).format('YYYY-MM-DD HH:mm:ss')
}, {
id: memberId

10
ghost/members-events-service/test/last-seen-at-updater.test.js
View file

@ -18,7 +18,7 @@ describe('LastSeenAtUpdater', function () {
new LastSeenAtUpdater({
models: {
Member: {
update: spy
edit: spy
}
},
services: {
@ -44,7 +44,7 @@ describe('LastSeenAtUpdater', function () {
new LastSeenAtUpdater({
models: {
Member: {
update: spy
edit: spy
}
},
services: {
@ -66,7 +66,7 @@ describe('LastSeenAtUpdater', function () {
new LastSeenAtUpdater({
models: {
Member: {
update: spy
edit: spy
}
},
services: {
@ -92,7 +92,7 @@ describe('LastSeenAtUpdater', function () {
new LastSeenAtUpdater({
models: {
Member: {
update: spy
edit: spy
}
},
services: {
@ -113,7 +113,7 @@ describe('LastSeenAtUpdater', function () {
new LastSeenAtUpdater({
models: {
Member: {
update: spy
edit: spy
}
},
services: {