Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

Added members-autoredirect data attribute selector. (#261)

Browse source 
closes https://github.com/TryGhost/Team/issues/1800
- Added data attribute selector for custom login / signup forms to optionally prevent redirects coming from the magic link.
This commit is contained in:
Ronald Langeveld 2022-09-06 14:39:18 +02:00 • committed by GitHub
parent 08cdddfb92
commit 30284909e9
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ghost/portal/src/data-attributes.js
View file

@ -11,6 +11,7 @@ function formSubmitHandler({event, form, errorEl, siteUrl, submitHandler}) {
form.classList.remove('success', 'invalid', 'error'); form.classList.remove('success', 'invalid', 'error');
let emailInput = event.target.querySelector('input[data-members-email]'); let emailInput = event.target.querySelector('input[data-members-email]');
let nameInput = event.target.querySelector('input[data-members-name]'); let nameInput = event.target.querySelector('input[data-members-name]');
let autoRedirect = form?.dataset?.membersAutoredirect || 'true';
let email = emailInput?.value; let email = emailInput?.value;
let name = (nameInput && nameInput.value) || undefined; let name = (nameInput && nameInput.value) || undefined;
let emailType = undefined; let emailType = undefined;
@ -36,7 +37,8 @@ function formSubmitHandler({event, form, errorEl, siteUrl, submitHandler}) {
email: email, email: email,
emailType: emailType, emailType: emailType,
labels: labels, labels: labels,
name: name name: name,
autoRedirect: (autoRedirect === 'true')
}) })
}).then(function (res) { }).then(function (res) {
form.addEventListener('submit', submitHandler); form.addEventListener('submit', submitHandler);

2
ghost/portal/src/tests/data-attributes.test.js
View file

@ -131,7 +131,7 @@ describe('Member Data attributes:', () => {
expect(window.fetch).toHaveBeenCalledTimes(1); expect(window.fetch).toHaveBeenCalledTimes(1);
expect(window.fetch).toHaveBeenCalledWith('https://portal.localhost/members/api/send-magic-link/', {body: '{"email":"jamie@example.com","emailType":"signup","labels":["Gold"],"name":"Jamie Larsen"}', headers: {'Content-Type': 'application/json'}, method: 'POST'}); expect(window.fetch).toHaveBeenCalledWith('https://portal.localhost/members/api/send-magic-link/', {body: `{"email":"jamie@example.com","emailType":"signup","labels":["Gold"],"name":"Jamie Larsen","autoRedirect":${true}}`, headers: {'Content-Type': 'application/json'}, method: 'POST'});
}); });
}); });