From 2ff151a8937e83154d25c72aeccb9b88a94dc101 Mon Sep 17 00:00:00 2001 From: Fabien O'Carroll Date: Wed, 10 Jun 2020 13:19:04 +0200 Subject: [PATCH] Added support for stripe connect test mode no-issue This adds the ability to pass a `mode` param of 'test' to the members stripe connect service, which will ensure we use a testmode client_id for the Stripe Connect OAuth flow. This will allow users to connect their account in testmode. --- core/server/services/members/stripe-connect.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/core/server/services/members/stripe-connect.js b/core/server/services/members/stripe-connect.js index b23fbb6f30..540f5db4dd 100644 --- a/core/server/services/members/stripe-connect.js +++ b/core/server/services/members/stripe-connect.js @@ -4,7 +4,8 @@ const {URL} = require('url'); const STATE_PROP = 'stripe-connect-state'; -const clientID = 'ca_8LBuZWhYshxF0A55KgCXu8PRTquCKC5x'; +const liveClientID = 'ca_8LBuZWhYshxF0A55KgCXu8PRTquCKC5x'; +const testClientID = 'ca_8LBum4Ctv3mmJ1oD0ZRmxjdAhNrrBUy3'; const redirectURI = 'https://stripe.ghost.org'; /** @@ -12,14 +13,17 @@ const redirectURI = 'https://stripe.ghost.org'; * @desc Returns a url for the auth endpoint for Stripe Connect, generates state and stores it on the session. * * @param {(prop: string, val: any) => Promise} setSessionProp - A function to set data on the current session + * @param {'live' | 'test'} mode - Which stripe mode to set up * * @returns {Promise} */ -async function getStripeConnectOAuthUrl(setSessionProp) { +async function getStripeConnectOAuthUrl(setSessionProp, mode = 'live') { const state = randomBytes(16).toString('hex'); await setSessionProp(STATE_PROP, state); + const clientID = mode === 'live' ? liveClientID : testClientID; + const authUrl = new URL('https://connect.stripe.com/oauth/authorize'); authUrl.searchParams.set('response_type', 'code'); authUrl.searchParams.set('scope', 'read_write');