Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

Fixed flaky Offers tests (#19170)

Browse source 
refs https://ghost.slack.com/archives/C02G9E68C/p1701258027793649

- missing an `await` before the `expect` in the test causing it to be potentially flaky.
This commit is contained in:
Ronald Langeveld 2023-11-29 13:55:54 +02:00 • committed by GitHub
parent 0b57c01dd9
commit 2f43f58010
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/admin-x-settings/test/acceptance/membership/offers.test.ts
View file

@ -80,7 +80,7 @@ test.describe('Offers Modal', () => {
}] }]
}); });
const successModal = page.getByTestId('offer-success-modal'); const successModal = page.getByTestId('offer-success-modal');
expect(successModal).toBeVisible(); await expect(successModal).toBeVisible();
}); });
test('Errors if required fields are missing', async ({page}) => { test('Errors if required fields are missing', async ({page}) => {