From 2d79ef7cf94c9e9968e740d1c5ab7608f28c1aee Mon Sep 17 00:00:00 2001 From: James Morris Date: Fri, 12 Aug 2022 09:29:29 +0100 Subject: [PATCH] Fixed local warnings in the terminal when building for comments no issue --- apps/comments-ui/src/components/Comment.js | 2 +- apps/comments-ui/src/components/CommentsBox.js | 8 ++++---- .../comments-ui/src/components/modals/AddDetailsDialog.js | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/apps/comments-ui/src/components/Comment.js b/apps/comments-ui/src/components/Comment.js index d141c36435..f3c91c7856 100644 --- a/apps/comments-ui/src/components/Comment.js +++ b/apps/comments-ui/src/components/Comment.js @@ -94,7 +94,7 @@ const Comment = ({updateIsEditing = null, isEditing, ...props}) => {
- {(!props.isReply && hasReplies || isInReplyMode) &&
} + {((!props.isReply && hasReplies) || isInReplyMode) &&
}
diff --git a/apps/comments-ui/src/components/CommentsBox.js b/apps/comments-ui/src/components/CommentsBox.js index 31b6709fc0..66fe559c2e 100644 --- a/apps/comments-ui/src/components/CommentsBox.js +++ b/apps/comments-ui/src/components/CommentsBox.js @@ -13,7 +13,7 @@ const CommentsBoxTitle = ({title, showCount, count}) => { return null; } - const Title = ({title}) => { + const Title = () => { if (title === null) { return ( <>Member discussion @@ -23,7 +23,7 @@ const CommentsBoxTitle = ({title, showCount, count}) => { return title; }; - const Count = ({showCount, count}) => { + const Count = () => { if (!showCount) { return null; } @@ -42,9 +42,9 @@ const CommentsBoxTitle = ({title, showCount, count}) => { return (

- + <Title /> </h2> - <Count showCount={showCount} count={count}/> + <Count /> </div> ); }; diff --git a/apps/comments-ui/src/components/modals/AddDetailsDialog.js b/apps/comments-ui/src/components/modals/AddDetailsDialog.js index b34a3f8384..846cab25c5 100644 --- a/apps/comments-ui/src/components/modals/AddDetailsDialog.js +++ b/apps/comments-ui/src/components/modals/AddDetailsDialog.js @@ -59,7 +59,7 @@ const AddNameDialog = (props) => { clearTimeout(timer); }; } - }, [inputNameRef, inputBioRef]); + }, [inputNameRef, inputBioRef, props.bioAutofocus]); const renderExampleProfiles = (index) => { const renderEl = (profile) => {