From 2a42ec5b412480256d6265c6fa12f6c53ae01d45 Mon Sep 17 00:00:00 2001
From: Aileen Nowak <aileen@ghost.org>
Date: Tue, 11 Apr 2017 16:10:56 +0700
Subject: [PATCH] =?UTF-8?q?=F0=9F=8E=A8=20=20Checkbox=20styles=20in=20sett?=
 =?UTF-8?q?ings=20(#633)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

no issue
- wraps the existing `{{one-way-checkbox}}` in general-setting in a `<label>` tag to make the checkbox styles work properly.
---
 ghost/admin/app/templates/settings/general.hbs | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/ghost/admin/app/templates/settings/general.hbs b/ghost/admin/app/templates/settings/general.hbs
index 30e49e767e..6b4a2fe76c 100644
--- a/ghost/admin/app/templates/settings/general.hbs
+++ b/ghost/admin/app/templates/settings/general.hbs
@@ -145,8 +145,12 @@
                 <div class="gh-setting-desc">Include the date in your post URLs, eg. <strong>blogurl.com/2017/01/post-title/</strong></div>
             </div>
             <div class="gh-setting-action">
-                {{one-way-checkbox isDatedPermalinks type="checkbox" update=(action (mut isDatedPermalinks)) data-test-dated-permalinks-checkbox=true}}
-                <span class="input-toggle-component"></span>
+                <div class="for-checkbox">
+                    <label class="checkbox" for="settings-dated-permalinks">
+                        {{one-way-checkbox isDatedPermalinks id="settings-dated-permalinks" type="checkbox" update=(action (mut isDatedPermalinks)) data-test-dated-permalinks-checkbox=true}}
+                        <span class="input-toggle-component"></span>
+                    </label>
+                </div>
             </div>
         </div>
         <div class="gh-setting">
@@ -164,8 +168,12 @@
                 {{/if}}
             </div>
             <div class="gh-setting-action">
-                {{one-way-checkbox model.isPrivate type="checkbox" update=(action (mut model.isPrivate)) data-test-private-checkbox=true}}
-                <span class="input-toggle-component"></span>
+                <div class="for-checkbox">
+                    <label class="checkbox" for="settings-private">
+                        {{one-way-checkbox model.isPrivate id="settings-private" type="checkbox" update=(action (mut model.isPrivate)) data-test-private-checkbox=true}}
+                        <span class="input-toggle-component"></span>
+                    </label>
+                </div>
             </div>
         </div>