From 2a119cc4a4e62b494b39d1d163df8c90677b8d9a Mon Sep 17 00:00:00 2001
From: Kevin Ansfield <kevin@ghost.org>
Date: Wed, 3 Apr 2024 17:46:38 +0100
Subject: [PATCH] Removed confirmation modal when dismissing onboarding
 (#19979)

closes https://linear.app/tryghost/issue/IPC-138/skip-onboarding-confirmation

- removed confirmation modal
- changed button to directly call the dismiss action on the onboarding service
---
 .../dashboard/onboarding-checklist.hbs        |  2 +-
 .../dashboard/onboarding-checklist.js         | 15 ---------------
 .../dashboard/onboarding/dismiss-modal.hbs    | 19 -------------------
 3 files changed, 1 insertion(+), 35 deletions(-)
 delete mode 100644 ghost/admin/app/components/dashboard/onboarding/dismiss-modal.hbs

diff --git a/ghost/admin/app/components/dashboard/onboarding-checklist.hbs b/ghost/admin/app/components/dashboard/onboarding-checklist.hbs
index 2b62d65347..cc3d0946f3 100644
--- a/ghost/admin/app/components/dashboard/onboarding-checklist.hbs
+++ b/ghost/admin/app/components/dashboard/onboarding-checklist.hbs
@@ -75,6 +75,6 @@
     <p class="gh-onboarding-help">More questions? Check out our <a href="https://ghost.org/help?utm_source=admin&utm_campaign=onboarding" target="_blank" rel="noopener noreferrer">Help Center</a>.</p>
 
     {{#unless this.onboarding.allStepsCompleted}}
-        <a href="#" class="gh-onboarding-skip" {{on "click" this.confirmDismiss}}>Skip onboarding</a>
+        <a href="#" class="gh-onboarding-skip" {{on "click" this.onboarding.dismissChecklist}}>Skip onboarding</a>
     {{/unless}}
 </div>
\ No newline at end of file
diff --git a/ghost/admin/app/components/dashboard/onboarding-checklist.js b/ghost/admin/app/components/dashboard/onboarding-checklist.js
index 4c5335319e..36861619ff 100644
--- a/ghost/admin/app/components/dashboard/onboarding-checklist.js
+++ b/ghost/admin/app/components/dashboard/onboarding-checklist.js
@@ -1,5 +1,4 @@
 import Component from '@glimmer/component';
-import DismissModal from './onboarding/dismiss-modal';
 import ShareModal from './onboarding/share-modal';
 import {action} from '@ember/object';
 import {inject} from 'ghost-admin/decorators/inject';
@@ -11,7 +10,6 @@ export default class OnboardingChecklist extends Component {
 
     @inject config;
 
-    dismissModal = null;
     shareModal = null;
 
     willDestroy() {
@@ -29,17 +27,4 @@ export default class OnboardingChecklist extends Component {
         this.onboarding.markStepCompleted('share-publication');
         this.shareModal = this.modals.open(ShareModal);
     }
-
-    @action
-    async confirmDismiss() {
-        this.dismissModal = this.modals.open(DismissModal, {}, {backgroundBlur: true});
-
-        const reallyDismiss = await this.dismissModal;
-
-        if (reallyDismiss === true) {
-            this.onboarding.dismissChecklist();
-        } else {
-            this.dismissModal = null;
-        }
-    }
 }
diff --git a/ghost/admin/app/components/dashboard/onboarding/dismiss-modal.hbs b/ghost/admin/app/components/dashboard/onboarding/dismiss-modal.hbs
deleted file mode 100644
index f597facba6..0000000000
--- a/ghost/admin/app/components/dashboard/onboarding/dismiss-modal.hbs
+++ /dev/null
@@ -1,19 +0,0 @@
-<div class="modal-content">
-    <header class="modal-header">
-        <h1>Are you sure you want to skip onboarding?</h1>
-    </header>
-    <button class="close" title="Close" type="button" {{on "click" @close}}>{{svg-jar "close"}}<span
-            class="hidden">Close</span></button>
-
-    <div class="modal-body">
-        <p>
-            We're here to guide you every step of the way, but if you're ready
-            to explore on your own, that's okay, too.
-        </p>
-    </div>
-
-    <div class="modal-footer">
-        <button class="gh-btn" type="button" {{on "click" @close}}><span>Cancel</span></button>
-        <button class="gh-btn gh-btn-black" type="button" {{on "click" (fn @close true)}}><span>Skip onboarding</span></button>
-    </div>
-</div>
\ No newline at end of file