From 28a2ff8259e478d833bb24bdde2bc611a3b4cb2f Mon Sep 17 00:00:00 2001 From: Kevin Ansfield Date: Mon, 1 Feb 2021 08:59:08 +0000 Subject: [PATCH] Fixed sending email preview from post preview modal refs https://github.com/TryGhost/Team/issues/459 - fixed incorrect tracked variable name for the email preview address - fixed incorrect access of `this.post` instead of `this.args.post` - re-throw any error that is encountered so the cause is not silently lost --- .../admin/app/components/modal-post-preview/email.js | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/ghost/admin/app/components/modal-post-preview/email.js b/ghost/admin/app/components/modal-post-preview/email.js index 8f9d087a24..6adcc96b72 100644 --- a/ghost/admin/app/components/modal-post-preview/email.js +++ b/ghost/admin/app/components/modal-post-preview/email.js @@ -27,14 +27,12 @@ export default class ModalPostPreviewEmailComponent extends Component { @tracked html = ''; @tracked subject = ''; - @tracked emailPreviewAddress = ''; + @tracked previewEmailAddress = ''; @tracked sendPreviewEmailError = ''; get mailgunIsEnabled() { return this.config.get('mailgunIsConfigured') || - this.settings.get('mailgunApiKey') && - this.settings.get('mailgunDomain') && - this.settings.get('mailgunBaseUrl'); + !!(this.settings.get('mailgunApiKey') && this.settings.get('mailgunDomain') && this.settings.get('mailgunBaseUrl')); } @action @@ -53,8 +51,8 @@ export default class ModalPostPreviewEmailComponent extends Component { @task({drop: true}) *sendPreviewEmailTask() { try { - const resourceId = this.post.id; - const testEmail = this.emailPreviewAddress.trim(); + const resourceId = this.args.post.id; + const testEmail = this.previewEmailAddress.trim(); if (!validator.isEmail(testEmail)) { this.sendPreviewEmailError = 'Please enter a valid email'; @@ -86,6 +84,7 @@ export default class ModalPostPreviewEmailComponent extends Component { } this.sendPreviewEmailError = message; + throw error; } } }