Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Added handling for empty query options

Browse source 
refs #9866

- it's fine if you pass e.g. `?formats=`
- same behaviour as v0.1
This commit is contained in:
kirrg001 2018-10-10 16:33:38 +02:00 • committed by Katharina Irrgang
parent 5d3b026cd9
commit 27714075b5
2 changed files with 22 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
core/server/api/shared/validators/input/all.js
View file

@ -49,6 +49,11 @@ const validate = (config, attrs) => {
if (allowedValues) {
debug('ctrl validation');
// CASE: we allow e.g. `formats=`
if (!value || !value.length) {
return;
}
const valuesAsArray = value.trim().toLowerCase().split(',');
const unallowedValues = _.filter(valuesAsArray, (value) => {
return !allowedValues.includes(value);

17
core/test/unit/api/shared/validators/input/all_spec.js
View file

@ -61,6 +61,23 @@ describe('Unit: api/shared/validators/input/all', function () {
});
});
it('allows empty values', function () {
const frame = {
options: {
context: {},
formats: ''
}
};
const apiConfig = {
options: {
formats: ['format1']
}
};
return shared.validators.input.all.all(apiConfig, frame);
});
it('default include array notation', function () {
const frame = {
options: {