From 26b7102451d2fc86a853b475d82a342c9be01f07 Mon Sep 17 00:00:00 2001 From: Jason Williams Date: Fri, 26 Dec 2014 02:26:55 +0000 Subject: [PATCH] Use an explicit action name in action helper No Issue - Clicking on the body of a modal dialog causes an unhandled exception in the console. Add an explicit action name to the helper. --- core/client/components/gh-modal-dialog.js | 3 ++- core/client/templates/components/gh-modal-dialog.hbs | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/core/client/components/gh-modal-dialog.js b/core/client/components/gh-modal-dialog.js index 04cc4860ec..143bb631cd 100644 --- a/core/client/components/gh-modal-dialog.js +++ b/core/client/components/gh-modal-dialog.js @@ -29,7 +29,8 @@ var ModalDialog = Ember.Component.extend({ confirm: function (type) { this.sendAction('confirm' + type); this.close(); - } + }, + noBubble: Ember.K }, klass: Ember.computed('type', 'style', function () { diff --git a/core/client/templates/components/gh-modal-dialog.hbs b/core/client/templates/components/gh-modal-dialog.hbs index 961fbceb58..2db98df465 100644 --- a/core/client/templates/components/gh-modal-dialog.hbs +++ b/core/client/templates/components/gh-modal-dialog.hbs @@ -1,6 +1,6 @@