Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

Removed state variable from setting SettingGroup

Browse source 
refs. https://github.com/TryGhost/Team/issues/3150

The state variable in the global setting group component in Admin X was unnecessary.
This commit is contained in:
Peter Zimon 2023-05-19 07:46:54 +02:00
parent da9c004aa6
commit 25ac93e7ca
1 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
ghost/admin-x-settings/src/admin-x-ds/settings/SettingGroup.tsx
View file

@ -1,5 +1,5 @@
import ButtonGroup from '../global/ButtonGroup';
import React, {useState} from 'react';
import React from 'react';
import SettingGroupHeader from './SettingGroupHeader';
import {IButton} from '../global/Button';
@ -17,12 +17,6 @@ interface SettingGroupProps {
}
const SettingGroup: React.FC<SettingGroupProps> = ({title, description, state, customHeader, customButtons, children, onStateChange, onSave}) => {
const [currentState, setCurrentState] = useState<TSettingGroupStates>('view');
if (state && state !== currentState) {
setCurrentState(state);
}
const handleEdit = () => {
if (onStateChange) {
onStateChange('edit');
@ -46,7 +40,7 @@ const SettingGroup: React.FC<SettingGroupProps> = ({title, description, state, c
let styles = '';
switch (currentState) {
switch (state) {
case 'edit':
styles = 'border-grey-500';
break;
@ -77,7 +71,7 @@ const SettingGroup: React.FC<SettingGroupProps> = ({title, description, state, c
}
];
if (currentState === 'unsaved') {
if (state === 'unsaved') {
editButtons.push(
{
label: 'Save',
@ -93,7 +87,7 @@ const SettingGroup: React.FC<SettingGroupProps> = ({title, description, state, c
{customHeader ? customHeader :
<SettingGroupHeader description={description} title={title!}>
{customButtons ? customButtons :
<ButtonGroup buttons={currentState === 'view' ? viewButtons : editButtons} link={true} />}
<ButtonGroup buttons={state === 'view' ? viewButtons : editButtons} link={true} />}
</SettingGroupHeader>
}
{children}