Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

Added consistent handling to empty mobiledoc

Browse source 
closes #10612

- Added handling for 'blank' mobiledoc structure which should be converted to '""' instead of '<p></p>'
This commit is contained in:
Nazar Gargol 2019-03-18 20:06:53 +08:00
parent 04857e8823
commit 2517e9dc65
2 changed files with 32 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
core/server/lib/mobiledoc/converters/mobiledoc-converter.js
View file

@ -108,7 +108,8 @@ module.exports = {
// Koenig keeps a blank paragraph at the end of a doc but we want to
// make sure it doesn't get rendered
let lastChild = rendered.result.lastChild;
if (lastChild && lastChild.tagName === 'P' && !lastChild.firstChild) {
if (lastChild && lastChild.tagName === 'P'
&& !(lastChild.firstChild && lastChild.firstChild.nodeValue)) {
rendered.result.removeChild(lastChild);
}

30
core/test/unit/lib/mobiledoc/converters/mobiledoc-converter_spec.js
View file

@ -77,6 +77,36 @@ describe('Mobiledoc converter', function () {
converter.render(mobiledoc, 2).should.eql('<p>Test</p>');
});
it('removes single blank paragraph', function () {
let mobiledoc = {
version: '0.3.1',
atoms: [],
cards: [],
markups: [],
sections: [
[1, 'p', []]
]
};
converter.render(mobiledoc, 2).should.eql('');
});
it('removes single blank paragraph with empty content', function () {
let mobiledoc = {
version: '0.3.1',
markups: [],
atoms: [],
cards: [],
sections: [
[1, 'p', [
[0, [], 0, '']
]]
]
};
converter.render(mobiledoc, 2).should.eql('');
});
it('adds id attributes to headings', function () {
let mobiledoc = {
version: '0.3.1',