Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

🎨 Improved Portal and Portal settings (#19584)

Browse source 
no issue

---------

Co-authored-by: Simon Backx <simon@ghost.org>
Co-authored-by: Djordje Vlaisavljevic <dzvlais@gmail.com>
This commit is contained in:
Sag 2024-01-26 10:38:00 +01:00 • committed by GitHub
parent 07dbcb0715
commit 24952ab3df
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 4 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
apps/admin-x-settings/src/components/settings/advanced/labs/AlphaFeatures.tsx
View file

@ -47,10 +47,6 @@ const features = [{
title: 'Tips & donations', title: 'Tips & donations',
description: 'Enables publishers to collect one-time payments', description: 'Enables publishers to collect one-time payments',
flag: 'tipsAndDonations' flag: 'tipsAndDonations'
},{
title: 'Filter by email disabled',
description: 'Allows filtering members by email disabled',
flag: 'filterEmailDisabled'
},{ },{
title: 'AdminX Demo', title: 'AdminX Demo',
description: 'Adds a navigation link to the AdminX demo app', description: 'Adds a navigation link to the AdminX demo app',
@ -59,10 +55,6 @@ const features = [{
title: 'New email addresses', title: 'New email addresses',
description: 'For self hosters, forces the usage of the mail.from config as from address for all outgoing emails', description: 'For self hosters, forces the usage of the mail.from config as from address for all outgoing emails',
flag: 'newEmailAddresses' flag: 'newEmailAddresses'
},{
title: 'Portal improvements',
description: 'Adds a bunch of improvements to portal and portal settings',
flag: 'portalImprovements'
}]; }];
const AlphaFeatures: React.FC = () => { const AlphaFeatures: React.FC = () => {

7
ghost/core/core/shared/labs.js
View file

@ -22,7 +22,8 @@ const GA_FEATURES = [
'signupForm', 'signupForm',
'recommendations', 'recommendations',
'listUnsubscribeHeader', 'listUnsubscribeHeader',
'filterEmailDisabled' 'filterEmailDisabled',
'portalImprovements'
]; ];
// NOTE: this allowlist is meant to be used to filter out any unexpected // NOTE: this allowlist is meant to be used to filter out any unexpected
@ -45,10 +46,8 @@ const ALPHA_FEATURES = [
'importMemberTier', 'importMemberTier',
'lexicalIndicators', 'lexicalIndicators',
// 'adminXOffers', // 'adminXOffers',
'filterEmailDisabled',
'adminXDemo', 'adminXDemo',
'newEmailAddresses', 'newEmailAddresses'
'portalImprovements'
]; ];
module.exports.GA_KEYS = [...GA_FEATURES]; module.exports.GA_KEYS = [...GA_FEATURES];

2
ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap
View file

@ -1155,7 +1155,7 @@ exports[`Settings API Edit Can edit a setting 2: [headers] 1`] = `
Object { Object {
"access-control-allow-origin": "http://127.0.0.1:2369", "access-control-allow-origin": "http://127.0.0.1:2369",
"cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0", "cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0",
"content-length": "4507", "content-length": "4535",
"content-type": "application/json; charset=utf-8", "content-type": "application/json; charset=utf-8",
"content-version": StringMatching /v\\\\d\\+\\\\\\.\\\\d\\+/, "content-version": StringMatching /v\\\\d\\+\\\\\\.\\\\d\\+/,
"etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/, "etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/,