Improve status codes

closes #2187
- added UnsupportedMediaTypeError (code: 415)
- added status code 201 if a new object was created
- Updated tests

core/server/api/db.js

@@ -43,7 +43,7 @@ db = {
                  * - If there is no path
                  * - If the name doesn't have json in it
                  */
-                return when.reject(new errors.InternalServerError('Please select a .json file to import.'));
+                return when.reject(new errors.UnsupportedMediaTypeError('Please select a .json file to import.'));
             }
 
             return api.settings.read({key: 'databaseVersion', context: { internal: true }}).then(function (response) {

core/server/api/index.js

@@ -208,6 +208,9 @@ http = function (apiMethod) {
                     }).then(function addLocationHeader(header) {
                         if (header) {
                             res.set({'Location': header});
+                            // The location header indicates that a new object was created.
+                            // In this case the status code should be 201 Created
+                            res.status(201);
                         }
 
                         // Add Content-Disposition Header

core/server/errors/index.js

@@ -12,6 +12,7 @@ var _                          = require('lodash'),
     RequestEntityTooLargeError = require('./requesttoolargeerror'),
     UnauthorizedError          = require('./unauthorizederror'),
     ValidationError            = require('./validationerror'),
+    UnsupportedMediaTypeError  = require('./unsupportedmediaerror'),
     EmailError                 = require('./emailerror'),
     errors,
 
@@ -258,4 +259,5 @@ module.exports.NoPermissionError          = NoPermissionError;
 module.exports.UnauthorizedError          = UnauthorizedError;
 module.exports.ValidationError            = ValidationError;
 module.exports.RequestEntityTooLargeError = RequestEntityTooLargeError;
+module.exports.UnsupportedMediaTypeError  = UnsupportedMediaTypeError;
 module.exports.EmailError                 = EmailError;

core/server/errors/unsupportedmediaerror.js

@@ -0,0 +1,15 @@
+// # Unsupported Media Type
+// Custom error class with status code and type prefilled.
+
+function UnsupportedMediaTypeError(message) {
+    this.message = message;
+    this.stack = new Error().stack;
+    this.code = 415;
+    this.type = this.name;
+}
+
+UnsupportedMediaTypeError.prototype = Object.create(Error.prototype);
+UnsupportedMediaTypeError.prototype.name = "UnsupportedMediaTypeError";
+
+
+module.exports = UnsupportedMediaTypeError;

core/test/functional/routes/api/notifications_test.js

@@ -86,7 +86,7 @@ describe('Notifications API', function () {
             request.post(testUtils.API.getApiQuery('notifications/'))
                 .set('X-CSRF-Token', csrfToken)
                 .send(newNotification)
-                .expect(200)
+                .expect(201)
                 .end(function (err, res) {
                     if (err) {
                         return done(err);
@@ -119,7 +119,7 @@ describe('Notifications API', function () {
             request.post(testUtils.API.getApiQuery('notifications/'))
                 .set('X-CSRF-Token', csrfToken)
                 .send(newNotification)
-                .expect(200)
+                .expect(201)
                 .end(function (err, res) {
                     if (err) {
                         return done(err);

core/test/functional/routes/api/posts_test.js

@@ -355,7 +355,7 @@ describe('Post API', function () {
             request.post(testUtils.API.getApiQuery('posts/?include=tags'))
                 .set('X-CSRF-Token', csrfToken)
                 .send(newPost)
-                .expect(200)
+                .expect(201)
                 .end(function (err, res) {
                     if (err) {
                         return done(err);
@@ -713,7 +713,7 @@ describe('Post API', function () {
             request.post(testUtils.API.getApiQuery('posts/'))
                 .set('X-CSRF-Token', csrfToken)
                 .send(newPost)
-                .expect(200)
+                .expect(201)
                 .end(function (err ,res) {
                     if (err) {
                         return done(err);