Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity

Switch channel filters to use strings not literals

Browse source 
fixes #6247

- GQL has a bug where literals starting with numbers are incorrectly parsed
- Using strings instead of literals is a workaround, but is probably safer anyway
This commit is contained in:
Hannah Wolfe 2015-12-20 14:46:43 +00:00
parent 968349236d
commit 20f102808a
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core/server/controllers/frontend/channel-config.js
View file

@ -13,7 +13,7 @@ getConfig = function getConfig(name) {
name: 'tag', name: 'tag',
route: '/' + config.routeKeywords.tag + '/:slug/', route: '/' + config.routeKeywords.tag + '/:slug/',
postOptions: { postOptions: {
filter: 'tags:%s' filter: 'tags:\'%s\''
}, },
data: { data: {
tag: { tag: {
@ -28,7 +28,7 @@ getConfig = function getConfig(name) {
name: 'author', name: 'author',
route: '/' + config.routeKeywords.author + '/:slug/', route: '/' + config.routeKeywords.author + '/:slug/',
postOptions: { postOptions: {
filter: 'author:%s' filter: 'author:\'%s\''
}, },
data: { data: {
author: { author: {

4
core/test/unit/rss_spec.js
View file

@ -304,7 +304,7 @@ describe('RSS', function () {
// test // test
res.send = function send(xmlData) { res.send = function send(xmlData) {
apiBrowseStub.calledOnce.should.be.true; apiBrowseStub.calledOnce.should.be.true;
apiBrowseStub.calledWith({page: 1, filter: 'tags:magic', include: 'author,tags,fields'}).should.be.true; apiBrowseStub.calledWith({page: 1, filter: 'tags:\'magic\'', include: 'author,tags,fields'}).should.be.true;
apiTagStub.calledOnce.should.be.true; apiTagStub.calledOnce.should.be.true;
xmlData.should.match(/<channel><title><!\[CDATA\[Magic - Test\]\]><\/title>/); xmlData.should.match(/<channel><title><!\[CDATA\[Magic - Test\]\]><\/title>/);
done(); done();
@ -322,7 +322,7 @@ describe('RSS', function () {
// test // test
res.send = function send(xmlData) { res.send = function send(xmlData) {
apiBrowseStub.calledOnce.should.be.true; apiBrowseStub.calledOnce.should.be.true;
apiBrowseStub.calledWith({page: 1, filter: 'author:joe', include: 'author,tags,fields'}).should.be.true; apiBrowseStub.calledWith({page: 1, filter: 'author:\'joe\'', include: 'author,tags,fields'}).should.be.true;
apiUserStub.calledOnce.should.be.true; apiUserStub.calledOnce.should.be.true;
xmlData.should.match(/<channel><title><!\[CDATA\[Joe Blogs - Test\]\]><\/title>/); xmlData.should.match(/<channel><title><!\[CDATA\[Joe Blogs - Test\]\]><\/title>/);
done(); done();