From 20870aa2faaef57526daa3eb15e429fef3739cf6 Mon Sep 17 00:00:00 2001 From: Daniel Lockyer Date: Mon, 20 Sep 2021 15:03:04 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Fixed=20sending=20emails=20via?= =?UTF-8?q?=20SES=20or=20non-standard=20SMTP=20config?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fixes https://linear.app/tryghost/issue/CORE-45/ - this commit fixes two email related issues: - SES transport: the auth mechanism was set up wrong and so none of the requests would go through. This now follows the docs on https://nodemailer.com/transports/ses/ - SMTP transport: the latest versions of Nodemailer don't seem to allow overriding of options if a service is present. I've filed https://github.com/nodemailer/nodemailer/issues/1327 but in the mean time, I assign the options back to the transporter object to ensure they always get applied - I've fixed this in our `@trghost/nodemailer` package and so this commit bumps that here --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index aad69b1c4f..d28731a74e 100644 --- a/package.json +++ b/package.json @@ -79,7 +79,7 @@ "@tryghost/members-importer": "0.3.2", "@tryghost/members-ssr": "1.0.12", "@tryghost/mw-session-from-token": "0.1.22", - "@tryghost/nodemailer": "0.3.1", + "@tryghost/nodemailer": "0.3.2", "@tryghost/package-json": "1.0.2", "@tryghost/promise": "0.1.9", "@tryghost/request": "0.1.5", diff --git a/yarn.lock b/yarn.lock index a90244c0f3..5a0a339a79 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1575,10 +1575,10 @@ resolved "https://registry.yarnpkg.com/@tryghost/mw-session-from-token/-/mw-session-from-token-0.1.22.tgz#eb060cca7c80e87b96a6b6f2e6e68a2660f2b36e" integrity sha512-9emJs6b+3/YLE2jlZ8+gZRmtTohUMS6d4lX9Gw/u3eABbGcoYOsaxc2/kqD6+xdizsFHQ93Qp7Jkw5knfI7XLA== -"@tryghost/nodemailer@0.3.1": - version "0.3.1" - resolved "https://registry.yarnpkg.com/@tryghost/nodemailer/-/nodemailer-0.3.1.tgz#7d8bddab1c8223c48f1e453a006e852770ecf92e" - integrity sha512-ewaSciSJkmJhgIH93f5H2dsREkYQH5T2F7ZYrUbX3RGhcvg9zBYQ1C1Xr5M/sHS6xzYXgz4IN/zBR9iTbH6kRw== +"@tryghost/nodemailer@0.3.2": + version "0.3.2" + resolved "https://registry.yarnpkg.com/@tryghost/nodemailer/-/nodemailer-0.3.2.tgz#983e6fe5cd46ecb9e419f673bb8bfefdc4282bfc" + integrity sha512-z5YPwncK6Gkr8SVL5JpS3XevkMZ1qT6ZQr6XWX4OkVPX2YozjEkyQBCriWw1ize9yzdZoFBvTA7G+z1EIRTvGg== dependencies: "@aws-sdk/client-ses" "^3.31.0" "@tryghost/errors" "^0.2.13"