✨ Enable Public API by default (#8600)

closes #8601 

- this doesn't take the feature out of beta, but does enable it by default
- no need to enable the public api in the test anymore
- because public api is enabled by default

core/server/data/schema/default-settings.json

@@ -73,7 +73,7 @@
             "defaultValue" : ""
         },
         "labs": {
-            "defaultValue": "{}"
+            "defaultValue": "{\"publicAPI\": true}"
         },
         "navigation": {
             "defaultValue": "[{\"label\":\"Home\", \"url\":\"/\"}]"

core/test/functional/routes/api/public_api_spec.js

@@ -7,37 +7,19 @@ var should = require('should'),
     request;
 
 describe('Public API', function () {
-    var publicAPIaccessSetting = {
+    var ghostServer;
-        settings: [
-            {key: 'labs', value: {publicAPI: true}}
-        ]
-    }, ghostServer;
 
-    before(function (done) {
+    before(function () {
         // starting ghost automatically populates the db
         // TODO: prevent db init, and manage bringing up the DB with fixtures ourselves
-        ghost().then(function (_ghostServer) {
+        return ghost().then(function (_ghostServer) {
             ghostServer = _ghostServer;
             return ghostServer.start();
         }).then(function () {
             request = supertest.agent(config.get('url'));
         }).then(function () {
             return testUtils.doAuth(request, 'posts', 'tags', 'client:trusted-domain');
-        }).then(function (token) {
+        });
-            // enable public API
-            request.put(testUtils.API.getApiQuery('settings/'))
-                .set('Authorization', 'Bearer ' + token)
-                .send(publicAPIaccessSetting)
-                .expect('Content-Type', /json/)
-                .expect('Cache-Control', testUtils.cacheRules.private)
-                .expect(200)
-                .end(function (err) {
-                    if (err) {
-                        return done(err);
-                    }
-                    done();
-                });
-        }).catch(done);
     });
 
     after(function () {