Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

Standardised mobiledocLib renderer access

Browse source 
no issue

- avoid accessing `mobiledocLib.mobiledocHtmlRenderer` directly to access the `render()` method in favor of using `mobiledocLib.render()` instead
- standardising on this pattern should help avoid accidentally requiring the full library before we have a need to render
This commit is contained in:
Kevin Ansfield 2024-10-09 17:16:49 +01:00
parent e136ecb09f
commit 2036747bef
5 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ghost/core/core/server/data/importer/importers/data/PostsImporter.js
View file

@ -271,10 +271,10 @@ class PostsImporter extends BaseImporter {
});
model.mobiledoc = JSON.stringify(mobiledoc);
model.html = mobiledocLib.mobiledocHtmlRenderer.render(JSON.parse(model.mobiledoc));
model.html = mobiledocLib.render(JSON.parse(model.mobiledoc));
} else if (model.html && !model.lexical) {
model.mobiledoc = JSON.stringify(mobiledocLib.htmlToMobiledocConverter(model.html));
model.html = mobiledocLib.mobiledocHtmlRenderer.render(JSON.parse(model.mobiledoc));
model.html = mobiledocLib.render(JSON.parse(model.mobiledoc));
}
this.sanitizePostsMeta(model);

2
ghost/core/core/server/data/migrations/versions/4.0/23-regenerate-posts-html.js
View file

@ -39,7 +39,7 @@ module.exports = createIrreversibleMigration(async (knex) => {
continue;
}
const html = mobiledocLib.mobiledocHtmlRenderer.render(mobiledoc);
const html = mobiledocLib.render(mobiledoc);
const updatedAttrs = {
html: html

2
ghost/core/core/server/data/migrations/versions/4.9/05-fix-missed-mobiledoc-url-transforms.js
View file

@ -59,7 +59,7 @@ module.exports = createTransactionalMigration(
}
try {
html = mobiledocLib.mobiledocHtmlRenderer.render(JSON.parse(mobiledoc));
html = mobiledocLib.render(JSON.parse(mobiledoc));
} catch (err) {
logging.warn(`Invalid mobiledoc content structure for ${id}, unable to render. Skipping`);
continue;

2
ghost/core/core/server/data/migrations/versions/5.0/2022-05-21-00-00-regenerate-posts-html.js
View file

@ -43,7 +43,7 @@ module.exports = createIrreversibleMigration(async (knex) => {
continue;
}
const html = mobiledocLib.mobiledocHtmlRenderer.render(mobiledoc);
const html = mobiledocLib.render(mobiledoc);
const updatedAttrs = {
html

2
ghost/core/core/server/models/post.js
View file

@ -742,7 +742,7 @@ Post = ghostBookshelf.Model.extend({
)
) {
try {
this.set('html', mobiledocLib.mobiledocHtmlRenderer.render(JSON.parse(this.get('mobiledoc'))));
this.set('html', mobiledocLib.render(JSON.parse(this.get('mobiledoc'))));
} catch (err) {
throw new errors.ValidationError({
message: tpl(messages.invalidMobiledocStructure),