Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-17 23:44:39 -05:00
Code Issues Activity

Fixed invalid NQL syntax when using "created on or after" filter

Browse source 
no issue

- the "on or after" filter generation was missing the trailing quote around the date literal causing an "Error parsing filter" error
This commit is contained in:
Kevin Ansfield 2022-03-03 10:11:08 +00:00
parent 8734143516
commit 20329c4d81
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/admin/app/components/members/filter.js
View file

@ -267,7 +267,7 @@ export default class MembersFilter extends Component {
}
if (operator === '>=') {
relationStr = '>=';
filterValue = `'${moment(filter.value).set({hour: 0, minute: 0, second: 0}).format(nqlDateFormat)}`;
filterValue = `'${moment(filter.value).set({hour: 0, minute: 0, second: 0}).format(nqlDateFormat)}'`;
}
if (operator === '<') {
relationStr = '<';

5
ghost/admin/tests/acceptance/members/filter-test.js
View file

@ -686,6 +686,11 @@ describe('Acceptance: Members filtering', function () {
expect(findAll('[data-test-list="members-list-item"]').length, '# of filtered member rows - from URL')
.to.equal(3);
// "on or after" doesn't break
await fillIn(operatorSelect, 'is-or-greater');
expect(findAll('[data-test-list="members-list-item"]').length, '# of filtered member rows - from URL')
.to.equal(7);
// it does not add extra column to table
expect(find('[data-test-table-column="created_at"]')).to.not.exist;
});