Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Fixed content-length in labs snapshot

Browse source 
refs: 22fd7f289c

- in the mentioned commit I changed the tests so that we don't need to update snapshots for every labs flag change
- this commit does the same for content-length which didn't get picked up locally, but does on CI for some reason
- the goal is to allow the team to add and remove flags without needing to update a random snapshot
This commit is contained in:
Hannah Wolfe 2022-08-19 10:51:43 +01:00
parent 30a9b5d1fa
commit 1fadbacdec
No known key found for this signature in database
GPG key ID: AB586C3B5AE5C037
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap
View file

@ -280,7 +280,7 @@ exports[`Settings API Browse Can request all settings 2: [headers] 1`] = `
Object { Object {
"access-control-allow-origin": "http://127.0.0.1:2369", "access-control-allow-origin": "http://127.0.0.1:2369",
"cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0", "cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0",
"content-length": "3452", "content-length": StringMatching /\\\\d\\+/,
"content-type": "application/json; charset=utf-8", "content-type": "application/json; charset=utf-8",
"etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/, "etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/,
"vary": "Origin, Accept-Encoding", "vary": "Origin, Accept-Encoding",

6
ghost/core/test/e2e-api/admin/settings.test.js
View file

@ -3,7 +3,7 @@ const SingleUseTokenProvider = require('../../../core/server/services/members/Si
const settingsService = require('../../../core/server/services/settings/settings-service'); const settingsService = require('../../../core/server/services/settings/settings-service');
const settingsCache = require('../../../core/shared/settings-cache'); const settingsCache = require('../../../core/shared/settings-cache');
const {agentProvider, fixtureManager, mockManager, matchers} = require('../../utils/e2e-framework'); const {agentProvider, fixtureManager, mockManager, matchers} = require('../../utils/e2e-framework');
const {stringMatching, anyEtag, anyUuid} = matchers; const {stringMatching, anyEtag, anyUuid, anyStringNumber} = matchers;
const models = require('../../../core/server/models'); const models = require('../../../core/server/models');
const {anyErrorId} = matchers; const {anyErrorId} = matchers;
@ -63,7 +63,9 @@ describe('Settings API', function () {
settings: matchSettingsArray(CURRENT_SETTINGS_COUNT) settings: matchSettingsArray(CURRENT_SETTINGS_COUNT)
}) })
.matchHeaderSnapshot({ .matchHeaderSnapshot({
etag: anyEtag etag: anyEtag,
// Special rule for this test, as the labs setting changes a lot
'content-length': anyStringNumber
}); });
}); });