Reduced amount of member count queries when opening the editor (#19474)

no issue

When we open the editor, we fire 4 requests to fetch member counts. This
commit fixes this by replacing those calls with the members count cache
service.

ghost/admin/app/components/gh-members-segment-count.js

@@ -6,6 +6,7 @@ import {tracked} from '@glimmer/tracking';
 export default class GhMembersSegmentCountComponent extends Component {
     @service store;
     @service session;
+    @service membersCountCache;
 
     @tracked total = 0;
     @tracked segmentTotal = 0;
@@ -17,9 +18,7 @@ export default class GhMembersSegmentCountComponent extends Component {
         this.fetchSegmentTotalTask.perform();
 
         const filter = this.args.enforcedFilter || undefined;
-
+        this.total = yield this.membersCountCache.count({filter});
-        const members = yield this.store.query('member', {limit: 1, filter});
-        this.total = members.meta.pagination.total;
     }
 
     @task({group: 'fetchTasks'})

ghost/admin/app/helpers/publish-options.js

@@ -9,6 +9,7 @@ export default class PublishOptionsResource extends Resource {
     @service session;
     @service settings;
     @service store;
+    @service membersCountCache;
 
     @inject config;
 
@@ -35,7 +36,7 @@ export default class PublishOptionsResource extends Resource {
     }
 
     _createPublishOptions(post) {
-        const {config, limit, settings, store} = this;
+        const {config, limit, settings, store, membersCountCache} = this;
 
         return new PublishOptions({
             config,
@@ -43,6 +44,7 @@ export default class PublishOptionsResource extends Resource {
             post,
             settings,
             store,
+            membersCountCache,
             user: this.session.user
         });
     }

ghost/admin/app/services/limit.js

@@ -27,6 +27,7 @@ class HostLimitError extends LimitError {
 export default class LimitsService extends Service {
     @service store;
     @service membersStats;
+    @service membersCountCache;
 
     @inject config;
 
@@ -93,10 +94,7 @@ export default class LimitsService extends Service {
     }
 
     async getMembersCount() {
-        const members = await this.store.query('member', {limit: 1});
+        return this.membersCountCache.count({});
-        const total = members.meta.pagination.total;
-
-        return total;
     }
 
     async getNewslettersCount() {

ghost/admin/app/utils/publish-options.js

@@ -10,6 +10,7 @@ export default class PublishOptions {
     limit = null;
     settings = null;
     store = null;
+    membersCountCache = null;
 
     // passed in models
     post = null;
@@ -234,13 +235,14 @@ export default class PublishOptions {
 
     // setup -------------------------------------------------------------------
 
-    constructor({config, limit, post, settings, store, user} = {}) {
+    constructor({config, limit, post, settings, store, user, membersCountCache} = {}) {
         this.config = config;
         this.limit = limit;
         this.post = post;
         this.settings = settings;
         this.store = store;
         this.user = user;
+        this.membersCountCache = membersCountCache;
 
         // this needs to be set here rather than a class-level property because
         // unlike Ember-based classes the services are not injected so can't be
@@ -285,8 +287,8 @@ export default class PublishOptions {
         // Only Admins/Owners have permission to browse members and get a count
         // for Editors/Authors set member count to 1 so email isn't disabled for not having any members
         if (this.user.isAdmin) {
-            promises.push(this.store.query('member', {limit: 1}).then((res) => {
+            promises.push(this.membersCountCache.count({}).then((res) => {
-                this.totalMemberCount = res.meta.pagination.total;
+                this.totalMemberCount = res;
             }));
         } else {
             this.totalMemberCount = 1;