From 1e7b6581480e9f868e6cf36a5ae865cb3273e42f Mon Sep 17 00:00:00 2001 From: Simon Backx Date: Mon, 5 Jun 2023 17:58:30 +0200 Subject: [PATCH] Updated sign up form to use resized version of icon fixes https://github.com/TryGhost/Team/issues/3345 The icon is now served as a 128x128px version --- .../admin/app/components/modals/settings/signup-form-embed.js | 4 +++- .../server/api/endpoints/utils/serializers/output/settings.js | 2 +- ghost/core/core/shared/config/overrides.json | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/ghost/admin/app/components/modals/settings/signup-form-embed.js b/ghost/admin/app/components/modals/settings/signup-form-embed.js index 8d1bba193f..9526ea4bb0 100644 --- a/ghost/admin/app/components/modals/settings/signup-form-embed.js +++ b/ghost/admin/app/components/modals/settings/signup-form-embed.js @@ -89,7 +89,9 @@ export default class SignupFormEmbedModal extends Component { let style = 'min-height: 58px'; if (this.style === 'all-in-one') { - options.logo = this.settings.icon; + // We serve twice the size of the icon to support high resolution screens + // (note that you'll need to change the resolution in the backend config as well, as not all resolutions are supported) + options.logo = this.settings.icon.replace(/\/content\/images\//, '/content/images/size/w128h128/'); options.title = this.settings.title; options.description = this.settings.description; diff --git a/ghost/core/core/server/api/endpoints/utils/serializers/output/settings.js b/ghost/core/core/server/api/endpoints/utils/serializers/output/settings.js index 60a49c427c..9a8c47f51a 100644 --- a/ghost/core/core/server/api/endpoints/utils/serializers/output/settings.js +++ b/ghost/core/core/server/api/endpoints/utils/serializers/output/settings.js @@ -33,7 +33,7 @@ function serializeSettings(models, apiConfig, frame) { // If this is public, we already have the right data, we just need to add an Array wrapper if (utils.isContentAPI(frame)) { filteredSettings = models; - + // Change the returned icon location to use a resized version, to prevent serving giant icon files const icon = filteredSettings.icon; if (icon) { diff --git a/ghost/core/core/shared/config/overrides.json b/ghost/core/core/shared/config/overrides.json index 2d9e8cb8d9..b4974408f1 100644 --- a/ghost/core/core/shared/config/overrides.json +++ b/ghost/core/core/shared/config/overrides.json @@ -121,6 +121,7 @@ }, "internalImageSizes": { "icon": {"width": 256, "height": 256}, + "signup-form-icon": {"width": 128, "height": 128}, "email-header-image": {"width": 1200}, "email-latest-posts-image": {"width": 200, "height": 200}, "email-latest-posts-image-mobile": {"width": 1200, "height": 960}