0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00

🐛 Fixed mail config not respecting disabled secure connections

refs https://forum.ghost.org/t/un-noticed-email-config-change-in-4-15-16/25869/6
refs https://linear.app/tryghost/issue/CORE-66/fixed-secureconnection-alias-for-nodemailer

- `secureConnection` was removed in Nodemailer 1.0.2 in favor of
  `secure` but we're locked into supporting it because a lot of
  our users will have it in their config
- I attempted to alias it to keep compatibility but I did this
  incorrectly and only handled the cases where it was set to `true`
- this meant users who had disabled secure connections were seeing SSL
  warnings because the library was trying to connect via SSL to a
  non-SSL endpoint
- the aliasing is fixed in `@tryghost/nodemailer` 0.3.3 and so this
  commit bumps the package in Ghost
This commit is contained in:
Daniel Lockyer 2021-09-28 14:45:39 +01:00
parent 9797787c4b
commit 1e5f28727d
No known key found for this signature in database
GPG key ID: D21186F0B47295AD
2 changed files with 5 additions and 5 deletions

View file

@ -80,7 +80,7 @@
"@tryghost/members-importer": "0.3.2",
"@tryghost/members-ssr": "1.0.14",
"@tryghost/mw-session-from-token": "0.1.23",
"@tryghost/nodemailer": "0.3.2",
"@tryghost/nodemailer": "0.3.3",
"@tryghost/package-json": "1.0.3",
"@tryghost/promise": "0.1.10",
"@tryghost/request": "0.1.5",

View file

@ -1576,10 +1576,10 @@
resolved "https://registry.yarnpkg.com/@tryghost/mw-session-from-token/-/mw-session-from-token-0.1.23.tgz#f9dd444cbaabe8c72192ad2f11328863d51ffa16"
integrity sha512-mDKg1g7Hb/fbk4XbfJHTqujTdmPBLrklonZbGYzuQyqhtZkO6JYLuaL2TSxQgabRGaJI2YQ5sL6hmIwPTT6z7Q==
"@tryghost/nodemailer@0.3.2":
version "0.3.2"
resolved "https://registry.yarnpkg.com/@tryghost/nodemailer/-/nodemailer-0.3.2.tgz#983e6fe5cd46ecb9e419f673bb8bfefdc4282bfc"
integrity sha512-z5YPwncK6Gkr8SVL5JpS3XevkMZ1qT6ZQr6XWX4OkVPX2YozjEkyQBCriWw1ize9yzdZoFBvTA7G+z1EIRTvGg==
"@tryghost/nodemailer@0.3.3":
version "0.3.3"
resolved "https://registry.yarnpkg.com/@tryghost/nodemailer/-/nodemailer-0.3.3.tgz#4a6662509a276b72b85abe1b687e5949e5a0cbbf"
integrity sha512-tj8WLm5J3ZL2ySs56OqUezjBJ777hrJ2MMOpreLK4ExAUK+hf8FW0EusXDWdLOggqllRc1QrSVLp2gRXkLSgGg==
dependencies:
"@aws-sdk/client-ses" "^3.31.0"
"@tryghost/errors" "^0.2.13"