Stopped type declaration files from being generated

refs https://github.com/TryGhost/Team/issues/870

- currently, a handful of packages in this repo generate type
  declarations when building
- we're aiming to go more in the direction of better inline jsdoc, and
  we want to clean up all generated files and use of external types
- this commit removes the `typescript` dependency, removes the pretest
  commands that run the builds, and cleans up anywhere where we
  configure types

ghost/adapter-manager/package.json

@@ -5,14 +5,11 @@
   "author": "Ghost Foundation",
   "license": "MIT",
   "main": "index.js",
-  "types": "types/index.d.ts",
   "scripts": {
     "dev": "echo \"Implement me!\"",
     "test": "NODE_ENV=testing c8 mocha './test/**/*.test.js'",
     "lint": "eslint . --ext .js --cache",
-    "posttest": "yarn lint",
-    "pretest": "yarn types",
-    "types": "rm -r types && yarn tsc"
+    "posttest": "yarn lint"
   },
   "files": [
     "index.js",
@@ -22,13 +19,10 @@
     "access": "public"
   },
   "devDependencies": {
-    "@types/mocha": "8.2.3",
-    "@types/sinon": "10.0.2",
     "c8": "7.7.3",
     "mocha": "9.0.0",
     "should": "13.2.3",
-    "sinon": "11.0.0",
-    "typescript": "4.3.5"
+    "sinon": "11.0.0"
   },
   "dependencies": {
     "@tryghost/errors": "^0.2.13"

ghost/adapter-manager/tsconfig.json

@@ -2,7 +2,6 @@
   "compilerOptions": {
     "declaration": true,
     "emitDeclarationOnly": true,
-    "outDir": "types",
     "allowJs": true,
     "checkJs": true,
     "module": "commonjs",

ghost/moleculer-service-from-class/package.json

@@ -9,8 +9,6 @@
     "dev": "echo \"Implement me!\"",
     "test": "NODE_ENV=testing c8 mocha './test/**/*.test.js'",
     "lint": "eslint . --ext .js --cache",
-    "types": "rm -rf types && tsc",
-    "pretest": "yarn types",
     "posttest": "yarn lint"
   },
   "files": [
@@ -24,8 +22,7 @@
     "c8": "7.7.3",
     "mocha": "9.0.0",
     "should": "13.2.3",
-    "sinon": "11.0.0",
-    "typescript": "4.3.5"
+    "sinon": "11.0.0"
   },
   "dependencies": {
     "moleculer": "^0.14.11"

ghost/moleculer-service-from-class/tsconfig.json

@@ -2,7 +2,6 @@
   "compilerOptions": {
     "declaration": true,
     "emitDeclarationOnly": true,
-    "outDir": "types",
     "allowJs": true,
     "checkJs": true,
     "module": "commonjs",

ghost/mw-session-from-token/package.json

@@ -9,8 +9,6 @@
     "dev": "echo \"Implement me!\"",
     "test": "NODE_ENV=testing c8 mocha './test/**/*.test.js'",
     "lint": "eslint . --ext .js --cache",
-    "types": "rm -r types && tsc",
-    "pretest": "yarn types",
     "posttest": "yarn lint"
   },
   "files": [
@@ -21,13 +19,10 @@
     "access": "public"
   },
   "devDependencies": {
-    "@types/express": "4.17.13",
-    "@types/mocha": "8.2.3",
     "c8": "7.7.3",
     "express": "4.17.1",
     "mocha": "9.0.0",
     "should": "13.2.3",
-    "sinon": "11.0.0",
-    "typescript": "4.3.5"
+    "sinon": "11.0.0"
   }
 }

ghost/mw-session-from-token/tsconfig.json

@@ -2,7 +2,6 @@
   "compilerOptions": {
     "declaration": true,
     "emitDeclarationOnly": true,
-    "outDir": "types",
     "allowJs": true,
     "checkJs": true,
     "module": "commonjs",

ghost/session-service/README.md

@@ -73,7 +73,6 @@ Follow the instructions for the top-level repo.
 
 ## Test
 
-- `yarn types` run just type check
 - `yarn lint` run just eslint
 - `yarn test` run lint and tests and type check
 

ghost/session-service/package.json

@@ -5,14 +5,11 @@
   "author": "Ghost Foundation",
   "license": "MIT",
   "main": "index.js",
-  "types": "./types/index.d.ts",
   "scripts": {
     "dev": "echo \"Implement me!\"",
     "test": "NODE_ENV=testing c8 mocha './test/**/*.test.js'",
     "lint": "eslint . --ext .js --cache",
-    "posttest": "yarn lint",
-    "pretest": "yarn types",
-    "types": "rm -r types && tsc"
+    "posttest": "yarn lint"
   },
   "files": [
     "index.js",
@@ -22,14 +19,11 @@
     "access": "public"
   },
   "devDependencies": {
-    "@types/express": "4.17.13",
-    "@types/mocha": "8.2.3",
     "c8": "7.7.3",
     "express": "4.17.1",
     "mocha": "9.0.0",
     "should": "13.2.3",
-    "sinon": "11.0.0",
-    "typescript": "4.3.5"
+    "sinon": "11.0.0"
   },
   "dependencies": {
     "@tryghost/errors": "^0.2.13"

ghost/session-service/tsconfig.json

@@ -2,7 +2,6 @@
   "compilerOptions": {
     "declaration": true,
     "emitDeclarationOnly": true,
-    "outDir": "types",
     "allowJs": true,
     "checkJs": true,
     "module": "commonjs",