Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity

Added ability to attach metadata to uploads

Browse source 
no-issue

Currently the onUploadSuccess and onUploadFailure have no way to
identify which upload has succeeded or failed other than the filename.
However the filename is not guaranteed to be unqiue, so this can cause
bugs.
This commit is contained in:
Fabien egg O'Carroll 2021-12-09 18:25:01 +02:00 • committed by Fabien 'egg' O'Carroll
parent f788cd6dfa
commit 1b9854b99f
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ghost/admin/app/components/gh-uploader.js
View file

@ -244,9 +244,10 @@ export default Component.extend({
let ajax = this.ajax;
let formData = this._getFormData(file);
let url = `${ghostPaths().apiRoot}${this.uploadUrl}`;
let metadata = null;
try {
this.onUploadStart(file);
metadata = yield Promise.resolve(this.onUploadStart(file));
let response = yield ajax[this.requestMethod](url, {
data: formData,
@ -296,7 +297,7 @@ export default Component.extend({
};
this.uploadUrls[index] = result;
this.onUploadSuccess(result);
this.onUploadSuccess(result, metadata);
return true;
} catch (error) {
@ -317,7 +318,7 @@ export default Component.extend({
// TODO: check for or expose known error types?
this.errors.pushObject(result);
this.onUploadFailure(result);
this.onUploadFailure(result, metadata);
}
}).maxConcurrency(MAX_SIMULTANEOUS_UPLOADS).enqueue(),