mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-01-27 22:49:56 -05:00
Added note on package/class naming
no issue - The name of the "StaffService" is ambiguous and too generic. Lack of good naming makes one to dig into the implementation details figuring out what the service does. - Should be named a more descriptive way
This commit is contained in:
parent
43f5547ae0
commit
1b526800f0
1 changed files with 2 additions and 0 deletions
|
@ -1,5 +1,7 @@
|
|||
const {MemberCreatedEvent, SubscriptionCancelledEvent, SubscriptionCreatedEvent} = require('@tryghost/member-events');
|
||||
|
||||
// @NOTE: 'StaffService' is a vague name that does not describe what it's actually doing.
|
||||
// Possibly, "StaffNotificationService" or "StaffEventNotificationService" would be a more accurate name
|
||||
class StaffService {
|
||||
constructor({logging, models, mailer, settingsCache, settingsHelpers, urlUtils, DomainEvents}) {
|
||||
this.logging = logging;
|
||||
|
|
Loading…
Add table
Reference in a new issue