From 1b38361211f52d5762b40cfb88f8d80bc745496e Mon Sep 17 00:00:00 2001 From: Simon Backx Date: Tue, 2 May 2023 10:23:45 +0200 Subject: [PATCH] Updated @sentry/node to v7.50.0 and reenabled renovate again fixes https://github.com/TryGhost/Team/issues/2385 The Sentry version has been locked to v7.11.1 for some time because Sentry still used a legacy Node feature, called domains. Due to a bug or change in in Noide 16+, those domains broke handling uncaught promise execptions. So Ghost crashed when a promise exception wasn't caught. But that shouldn't be the case because we have a global uncaught exception handler. Luckily Sentry switched to AsyncLocalStorage in v7.48.0. This fixes the issue as demonstrated in https://github.com/SimonBackx/sentry-node-unhandled-rejection-crash/commit/c0cd62184c18d42254cae6e4dd5d99b24e0ac8db --- ghost/core/package.json | 2 +- package.json | 1 - yarn.lock | 90 ++++++++++++++++++++--------------------- 3 files changed, 46 insertions(+), 47 deletions(-) diff --git a/ghost/core/package.json b/ghost/core/package.json index d2c01e148e..095aa1c059 100644 --- a/ghost/core/package.json +++ b/ghost/core/package.json @@ -58,7 +58,7 @@ "cli": "^1.17.0" }, "dependencies": { - "@sentry/node": "7.11.1", + "@sentry/node": "7.50.0", "@tryghost/adapter-base-cache": "0.1.5", "@tryghost/adapter-cache-redis": "0.0.0", "@tryghost/adapter-manager": "0.0.0", diff --git a/package.json b/package.json index bcf0d88f28..d9872c68b4 100644 --- a/package.json +++ b/package.json @@ -63,7 +63,6 @@ "validator", "codemirror", "faker", - "@sentry/node", "ember-cli-code-coverage" ], "ignorePaths": [ diff --git a/yarn.lock b/yarn.lock index 675aefb16b..2ec3ba81cf 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4081,6 +4081,16 @@ "@sentry/utils" "7.49.0" tslib "^1.9.3" +"@sentry-internal/tracing@7.50.0": + version "7.50.0" + resolved "https://registry.yarnpkg.com/@sentry-internal/tracing/-/tracing-7.50.0.tgz#74454af99a03d81762993835d2687c881e14f41e" + integrity sha512-4TQ4vN0aMBWsUXfJWk2xbe4x7fKfwCXgXKTtHC/ocwwKM+0EefV5Iw9YFG8IrIQN4vMtuRzktqcs9q0/Sbv7tg== + dependencies: + "@sentry/core" "7.50.0" + "@sentry/types" "7.50.0" + "@sentry/utils" "7.50.0" + tslib "^1.9.3" + "@sentry/browser@7.49.0": version "7.49.0" resolved "https://registry.yarnpkg.com/@sentry/browser/-/browser-7.49.0.tgz#5ce1cdb8d883c129d9a4e313c08a54c5ada4661b" @@ -4093,16 +4103,6 @@ "@sentry/utils" "7.49.0" tslib "^1.9.3" -"@sentry/core@7.11.1": - version "7.11.1" - resolved "https://registry.yarnpkg.com/@sentry/core/-/core-7.11.1.tgz#d68e796f3b6428aefd6086a1db00118df7a9a9e4" - integrity sha512-kaDSZ6VNuO4ZZdqUOOX6XM6x+kjo2bMnDQ3IJG51FPvVjr8lXYhXj1Ccxcot3pBYAIWPPby2+vNDOXllmXqoBA== - dependencies: - "@sentry/hub" "7.11.1" - "@sentry/types" "7.11.1" - "@sentry/utils" "7.11.1" - tslib "^1.9.3" - "@sentry/core@7.46.0": version "7.46.0" resolved "https://registry.yarnpkg.com/@sentry/core/-/core-7.46.0.tgz#f377e556d8679f29bde1cce15b1682b6c689d6b7" @@ -4121,6 +4121,15 @@ "@sentry/utils" "7.49.0" tslib "^1.9.3" +"@sentry/core@7.50.0": + version "7.50.0" + resolved "https://registry.yarnpkg.com/@sentry/core/-/core-7.50.0.tgz#88bc9cbfc0cb429a28489ece6f0be7a7006436c4" + integrity sha512-6oD1a3fYs4aiNK7tuJSd88LHjYJAetd7ZK/AfJniU7zWKj4jxIYfO8nhm0qdnhEDs81RcweVDmPhWm3Kwrzzsg== + dependencies: + "@sentry/types" "7.50.0" + "@sentry/utils" "7.50.0" + tslib "^1.9.3" + "@sentry/ember@7.49.0": version "7.49.0" resolved "https://registry.yarnpkg.com/@sentry/ember/-/ember-7.49.0.tgz#dcc3259cdde5a2c15eaf06fa4c1703163d295bcf" @@ -4135,29 +4144,6 @@ ember-cli-htmlbars "^6.1.1" ember-cli-typescript "^5.1.1" -"@sentry/hub@7.11.1": - version "7.11.1" - resolved "https://registry.yarnpkg.com/@sentry/hub/-/hub-7.11.1.tgz#1749b2b102ea1892ff388d65d66d3b402b393958" - integrity sha512-M6ClgdXdptS0lUBKB5KpXXe2qMQhsoiEN2pEGRI6+auqhfHCUQB1ZXsfjiOYexKC9fwx7TyFyZ9Jcaf2DTxEhw== - dependencies: - "@sentry/types" "7.11.1" - "@sentry/utils" "7.11.1" - tslib "^1.9.3" - -"@sentry/node@7.11.1": - version "7.11.1" - resolved "https://registry.yarnpkg.com/@sentry/node/-/node-7.11.1.tgz#97fd26de26e8203a3c34e26b38f3c2a5ba46828b" - integrity sha512-EAAHou/eHSzwRK0Z5qnQiwXNbkpnjWjloaG979gftA+MS/kM0AxQHdOrSJQbOEaqRf3F7/eC4Hj+1tfglAuaLQ== - dependencies: - "@sentry/core" "7.11.1" - "@sentry/hub" "7.11.1" - "@sentry/types" "7.11.1" - "@sentry/utils" "7.11.1" - cookie "^0.4.1" - https-proxy-agent "^5.0.0" - lru_map "^0.3.3" - tslib "^1.9.3" - "@sentry/node@7.46.0": version "7.46.0" resolved "https://registry.yarnpkg.com/@sentry/node/-/node-7.46.0.tgz#f85ee74926372d19d6b6a23f68f19023d7a528a7" @@ -4172,6 +4158,20 @@ lru_map "^0.3.3" tslib "^1.9.3" +"@sentry/node@7.50.0": + version "7.50.0" + resolved "https://registry.yarnpkg.com/@sentry/node/-/node-7.50.0.tgz#d6adab136d87f7dca614ea0d77944f902fa45626" + integrity sha512-11UJBKoQFMp7f8sbzeO2gENsKIUkVCNBTzuPRib7l2K1HMjSfacXmwwma7ZEs0mc3ofIZ1UYuyONAXmI1lK9cQ== + dependencies: + "@sentry-internal/tracing" "7.50.0" + "@sentry/core" "7.50.0" + "@sentry/types" "7.50.0" + "@sentry/utils" "7.50.0" + cookie "^0.4.1" + https-proxy-agent "^5.0.0" + lru_map "^0.3.3" + tslib "^1.9.3" + "@sentry/react@7.49.0": version "7.49.0" resolved "https://registry.yarnpkg.com/@sentry/react/-/react-7.49.0.tgz#9a31808d4232d3010019e09d7c706b3d4fe54960" @@ -4199,11 +4199,6 @@ dependencies: "@sentry-internal/tracing" "7.49.0" -"@sentry/types@7.11.1": - version "7.11.1" - resolved "https://registry.yarnpkg.com/@sentry/types/-/types-7.11.1.tgz#06e2827f6ba37159c33644208a0453b86d25e232" - integrity sha512-gIEhOPxC2cjrxQ0+K2SFJ1P6e/an5osSxVc9OOtekN28eHtVsXFCLB8XVWeNQnS7N2VkrVrkqORMBz1kvIcvVQ== - "@sentry/types@7.46.0": version "7.46.0" resolved "https://registry.yarnpkg.com/@sentry/types/-/types-7.46.0.tgz#8573ba8676342c594fcfefff4552123278cfec51" @@ -4214,13 +4209,10 @@ resolved "https://registry.yarnpkg.com/@sentry/types/-/types-7.49.0.tgz#2c217091e13dc373682f5be2e9b5baed9d2ae695" integrity sha512-9yXXh7iv76+O6h2ONUVx0wsL1auqJFWez62mTjWk4350SgMmWp/zUkBxnVXhmcYqscz/CepC+Loz9vITLXtgxg== -"@sentry/utils@7.11.1": - version "7.11.1" - resolved "https://registry.yarnpkg.com/@sentry/utils/-/utils-7.11.1.tgz#1635c5b223369d9428bc83c9b8908c9c3287ee10" - integrity sha512-tRVXNT5O9ilkV31pyHeTqA1PcPQfMV/2OR6yUYM4ah+QVISovC0f0ybhByuH5nYg6x/Gsnx1o7pc8L1GE3+O7A== - dependencies: - "@sentry/types" "7.11.1" - tslib "^1.9.3" +"@sentry/types@7.50.0": + version "7.50.0" + resolved "https://registry.yarnpkg.com/@sentry/types/-/types-7.50.0.tgz#52a035cad83a80ca26fa53c09eb1241250c3df3e" + integrity sha512-Zo9vyI98QNeYT0K0y57Rb4JRWDaPEgmp+QkQ4CRQZFUTWetO5fvPZ4Gb/R7TW16LajuHZlbJBHmvmNj2pkL2kw== "@sentry/utils@7.46.0": version "7.46.0" @@ -4238,6 +4230,14 @@ "@sentry/types" "7.49.0" tslib "^1.9.3" +"@sentry/utils@7.50.0": + version "7.50.0" + resolved "https://registry.yarnpkg.com/@sentry/utils/-/utils-7.50.0.tgz#2b93a48024651436e95b7c8e2066aee7c2234d57" + integrity sha512-iyPwwC6fwJsiPhH27ZbIiSsY5RaccHBqADS2zEjgKYhmP4P9WGgHRDrvLEnkOjqQyKNb6c0yfmv83n0uxYnolw== + dependencies: + "@sentry/types" "7.50.0" + tslib "^1.9.3" + "@sidvind/better-ajv-errors@^2.0.0": version "2.1.0" resolved "https://registry.yarnpkg.com/@sidvind/better-ajv-errors/-/better-ajv-errors-2.1.0.tgz#54f4216d2200d60e90ec25c6a27c1ea3afdc6cdf"