mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-10 23:36:14 -05:00
Added name
attribute to feature flag checkboxes
no issue - added `name` prop to `<Toggle>` component that corresponds to the checkbox's `name` attribute - updated `<FeatureToggle>` to set the `name` prop on it's `<Toggle>` component to the feature flag that was passed in so all feature toggles get a useful name attribute without having to manually specify one
This commit is contained in:
parent
2db35abc3c
commit
1a1ca3e91d
2 changed files with 4 additions and 1 deletions
|
@ -9,6 +9,7 @@ export type ToggleDirections = 'ltr' | 'rtl';
|
||||||
export interface ToggleProps {
|
export interface ToggleProps {
|
||||||
checked?: boolean;
|
checked?: boolean;
|
||||||
disabled?: boolean;
|
disabled?: boolean;
|
||||||
|
name?: string;
|
||||||
error?: boolean;
|
error?: boolean;
|
||||||
size?: ToggleSizes;
|
size?: ToggleSizes;
|
||||||
label?: React.ReactNode;
|
label?: React.ReactNode;
|
||||||
|
@ -33,6 +34,7 @@ const Toggle: React.FC<ToggleProps> = ({
|
||||||
error,
|
error,
|
||||||
checked,
|
checked,
|
||||||
disabled,
|
disabled,
|
||||||
|
name,
|
||||||
onChange
|
onChange
|
||||||
}) => {
|
}) => {
|
||||||
const id = useId();
|
const id = useId();
|
||||||
|
@ -95,6 +97,7 @@ const Toggle: React.FC<ToggleProps> = ({
|
||||||
)}
|
)}
|
||||||
disabled={disabled}
|
disabled={disabled}
|
||||||
id={id}
|
id={id}
|
||||||
|
name={name}
|
||||||
role="switch"
|
role="switch"
|
||||||
type="checkbox"
|
type="checkbox"
|
||||||
onChange={onChange} />
|
onChange={onChange} />
|
||||||
|
|
|
@ -13,7 +13,7 @@ const FeatureToggle: React.FC<{ flag: string; label?: string; }> = ({label, flag
|
||||||
const client = useQueryClient();
|
const client = useQueryClient();
|
||||||
const handleError = useHandleError();
|
const handleError = useHandleError();
|
||||||
|
|
||||||
return <Toggle checked={labs[flag]} label={label} labelClasses='sr-only' onChange={async () => {
|
return <Toggle checked={labs[flag]} label={label} labelClasses='sr-only' name={`feature-${flag}`} onChange={async () => {
|
||||||
const newValue = !labs[flag];
|
const newValue = !labs[flag];
|
||||||
try {
|
try {
|
||||||
await editSettings([{
|
await editSettings([{
|
||||||
|
|
Loading…
Add table
Reference in a new issue