Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity

Push some more style tweaks for iFrame but it may need more

Browse source 
- Includes more dynamic styling for negative margins for iFrames
- This may well change again when looking more closely with themes

refs https://github.com/TryGhost/Team/issues/1701
This commit is contained in:
James Morris 2022-07-21 15:33:04 +01:00
parent dd8715fa46
commit 15b534f7d3
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
apps/comments-ui/src/components/CommentsBox.js
View file

@ -69,8 +69,8 @@ const CommentsBox = (props) => {
const style = { const style = {
'--gh-accent-color': accentColor ?? 'blue', '--gh-accent-color': accentColor ?? 'blue',
// need careful padding adjustments to match iFrame negative margins and to not cut off top editing form // need careful padding adjustments to match iFrame negative margins and to not cut off top editing form
paddingLeft: 32, paddingLeft: 'min(4vmin,20px)',
paddingRight: 32, paddingRight: 'min(4vmin,20px)',
paddingTop: 16, paddingTop: 16,
paddingBottom: 16 paddingBottom: 16
}; };

6
apps/comments-ui/src/components/Frame.js
View file

@ -28,10 +28,10 @@ const Frame = ({
// For now we don't listen for type changes, we could consider adding useEffect, but that won't be used // For now we don't listen for type changes, we could consider adding useEffect, but that won't be used
const defaultStyle = type === 'dynamic' ? { const defaultStyle = type === 'dynamic' ? {
width: 'calc(100% + 64px)', width: 'calc(100% + min(8vmin, 40px))',
height: '400px', height: '400px',
marginLeft: '-32px', // negative margins to handle comment alignments and shadows marginLeft: 'max(-4vmin,-20px)', // negative margins to handle comment alignments and shadows
marginRight: '-32px' marginRight: 'max(-4vmin,-20px)'
} : { } : {
zIndex: '3999999', zIndex: '3999999',
position: 'fixed', position: 'fixed',