From 1500881923a2e85369903d2820f1667f51b16f1d Mon Sep 17 00:00:00 2001
From: Fabien O'Carroll <fabien@allou.is>
Date: Fri, 11 Oct 2019 12:16:57 +0700
Subject: [PATCH] Renamed getRequirePaymentSetting

no-issue

The negation before this function call was a little easy to miss for me
---
 core/server/services/members/api.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/core/server/services/members/api.js b/core/server/services/members/api.js
index 7efde87625..e8346a3f33 100644
--- a/core/server/services/members/api.js
+++ b/core/server/services/members/api.js
@@ -171,9 +171,9 @@ function getAuthSecret() {
     return secret;
 }
 
-function getRequirePaymentSetting() {
+function getAllowSelfSignup() {
     const subscriptionSettings = settingsCache.get('members_subscription_settings');
-    return !!subscriptionSettings.requirePaymentForSignup;
+    return !subscriptionSettings.requirePaymentForSignup;
 }
 
 // NOTE: the function is an exact duplicate of one in GhostMailer should be extracted
@@ -199,7 +199,7 @@ function createApiInstance() {
                 signinURL.searchParams.set('action', type);
                 return signinURL.href;
             },
-            allowSelfSignup: !getRequirePaymentSetting(),
+            allowSelfSignup: getAllowSelfSignup(),
             secret: getAuthSecret()
         },
         mail: {