Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Renamed newsletter to newsletter_name in post metrics export

Browse source 
no issue
This commit is contained in:
Simon Backx 2023-03-28 11:42:30 +02:00
parent 59f94e552a
commit 147e0cc0d5
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ghost/posts-service/lib/PostsExporter.js
View file

@ -83,7 +83,7 @@ class PostsExporter {
tags: post.related('tags').map(tag => tag.get('name')).join(', '),
post_access: this.postAccessToString(post),
email_recipients: email ? this.humanReadableEmailRecipientFilter(email?.get('recipient_filter'), labels) : null,
newsletter: newsletters.length > 1 && post.get('newsletter_id') && email ? newsletters.find(newsletter => newsletter.get('id') === post.get('newsletter_id'))?.get('name') : null,
newsletter_name: newsletters.length > 1 && post.get('newsletter_id') && email ? newsletters.find(newsletter => newsletter.get('id') === post.get('newsletter_id'))?.get('name') : null,
sends: email?.get('email_count') ?? null,
opens: trackOpens ? (email?.get('opened_count') ?? null) : null,
clicks: showEmailClickAnalytics ? (post.get('count__clicks') ?? 0) : null,
@ -99,7 +99,7 @@ class PostsExporter {
const removeableColumns = [];
if (newsletters.length <= 1) {
removeableColumns.push('newsletter');
removeableColumns.push('newsletter_name');
}
if (!membersEnabled) {

8
ghost/posts-service/test/PostsExporter.test.js
View file

@ -116,7 +116,7 @@ describe('PostsExporter', function () {
assert.equal(posts.length, 1);
// Hides newsletter column
assert.equal(posts[0].newsletter, undefined);
assert.equal(posts[0].newsletter_name, undefined);
});
it('Adds newsletter columns if multiple newsletters', async function () {
@ -134,8 +134,8 @@ describe('PostsExporter', function () {
assert.equal(posts.length, 2);
// Shows newsletter column
assert.equal(posts[0].newsletter, 'Daily Newsletter');
assert.equal(posts[1].newsletter, 'Weekly Newsletter');
assert.equal(posts[0].newsletter_name, 'Daily Newsletter');
assert.equal(posts[1].newsletter_name, 'Weekly Newsletter');
// Shows feedback columns
assert.equal(posts[0].reacted_with_more_like_this, post.count__positive_feedback);
@ -169,7 +169,7 @@ describe('PostsExporter', function () {
assert.equal(posts[0].sends, undefined);
assert.equal(posts[0].opens, undefined);
assert.equal(posts[0].clicks, undefined);
assert.equal(posts[0].newsletter, undefined);
assert.equal(posts[0].newsletter_name, undefined);
// Signups
assert.equal(posts[0].free_signups, undefined);