Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-27 22:49:56 -05:00
Code Issues Activity

Dropped nullable from members_subscribe_events.newsletter_id (#14656)

Browse source 
closes https://github.com/TryGhost/Team/issues/1570

- Includes utils to disable foreign key checks when dropping nullable from columns
- Migration to drop nullable from members_subscribe_events.newsletter_id
This commit is contained in:
Simon Backx 2022-05-03 16:30:07 +02:00 • committed by GitHub
parent 18ad847211
commit 12f569ebf9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 44 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
core/server/data/migrations/utils.js
View file

@ -3,6 +3,7 @@ const logging = require('@tryghost/logging');
const errors = require('@tryghost/errors'); const errors = require('@tryghost/errors');
const tpl = require('@tryghost/tpl'); const tpl = require('@tryghost/tpl');
const commands = require('../schema').commands; const commands = require('../schema').commands;
const DatabaseInfo = require('@tryghost/database-info');
const MIGRATION_USER = 1; const MIGRATION_USER = 1;
@ -443,18 +444,32 @@ function createDropColumnMigration(table, column, columnDefinition) {
/** /**
* @param {string} table * @param {string} table
* @param {string} column * @param {string} column
* * @param {Object} options
* @param {boolean} options.disableForeignKeyChecks Disable foreign key checks for the down operation (when dropping nullable)
* @returns {Migration} * @returns {Migration}
*/ */
function createSetNullableMigration(table, column) { function createSetNullableMigration(table, column, options = {}) {
return createNonTransactionalMigration( return createTransactionalMigration(
async function up(knex) { async function up(knex) {
logging.info(`Setting nullable: ${table}.${column}`); logging.info(`Setting nullable: ${table}.${column}`);
await commands.setNullable(table, column, knex); await commands.setNullable(table, column, knex);
}, },
async function down(knex) { async function down(knex) {
logging.info(`Dropping nullable: ${table}.${column}`); if (DatabaseInfo.isSQLite(knex)) {
await commands.dropNullable(table, column, knex); options.disableForeignKeyChecks = false;
}
logging.info(`Dropping nullable: ${table}.${column}${options.disableForeignKeyChecks ? ' with foreign keys disabled' : ''}`);
if (options.disableForeignKeyChecks) {
await knex.raw('SET FOREIGN_KEY_CHECKS=0;').transacting(knex);
}
try {
await commands.dropNullable(table, column, knex);
} finally {
if (options.disableForeignKeyChecks) {
await knex.raw('SET FOREIGN_KEY_CHECKS=1;').transacting(knex);
}
}
} }
); );
} }
@ -462,14 +477,29 @@ function createSetNullableMigration(table, column) {
/** /**
* @param {string} table * @param {string} table
* @param {string} column * @param {string} column
* * @param {Object} options
* @param {boolean} options.disableForeignKeyChecks Disable foreign key checks for the up operation (when dropping nullable)
* @returns {Migration} * @returns {Migration}
*/ */
function createDropNullableMigration(table, column) { function createDropNullableMigration(table, column, options = {}) {
return createNonTransactionalMigration( return createTransactionalMigration(
async function up(knex) { async function up(knex) {
logging.info(`Dropping nullable: ${table}.${column}`); if (DatabaseInfo.isSQLite(knex)) {
await commands.dropNullable(table, column, knex); options.disableForeignKeyChecks = false;
}
logging.info(`Dropping nullable: ${table}.${column}${options.disableForeignKeyChecks ? ' with foreign keys disabled' : ''}`);
if (options.disableForeignKeyChecks) {
await knex.raw('SET FOREIGN_KEY_CHECKS=0;').transacting(knex);
}
try {
await commands.dropNullable(table, column, knex);
} finally {
if (options.disableForeignKeyChecks) {
await knex.raw('SET FOREIGN_KEY_CHECKS=1;').transacting(knex);
}
}
}, },
async function down(knex) { async function down(knex) {
logging.info(`Setting nullable: ${table}.${column}`); logging.info(`Setting nullable: ${table}.${column}`);

4
core/server/data/migrations/versions/5.0/2022-05-03-09-39-drop-nullable-subscribe-event-newsletter-id.js Normal file
View file

@ -0,0 +1,4 @@
const {createDropNullableMigration} = require('../../utils');
// We need to disable foreign key checks because if MySQL is missing the STRICT_TRANS_TABLES mode, we cannot drop nullable from a foreign key
module.exports = createDropNullableMigration('members_subscribe_events', 'newsletter_id', {disableForeignKeyChecks: true});