Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

Upgraded migration lint warnings to errors

Browse source 
- we have these rules in place to force the developer to think about the
  performance impact of their code
- unless they are enforced, it's easy for them to slip by and miss them
- this commit changes the warnings to errors, which will fail CI
- developers still have the ability to disable lines that flag the
  linting in case there is a valid use-case
This commit is contained in:
Daniel Lockyer 2022-05-10 08:14:05 +01:00
parent c753d61be6
commit 10390e3408
No known key found for this signature in database
GPG key ID: D21186F0B47295AD
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.eslintrc.js
View file

@ -36,7 +36,7 @@ module.exports = {
{ {
files: 'core/server/data/migrations/versions/**', files: 'core/server/data/migrations/versions/**',
rules: { rules: {
'no-restricted-syntax': ['warn', { 'no-restricted-syntax': ['error', {
selector: 'ForStatement', selector: 'ForStatement',
message: 'For statements can perform badly in migrations' message: 'For statements can perform badly in migrations'
}, { }, {