Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-25 02:31:59 -05:00
Code Issues Activity

Merge pull request #3604 from PaulAdamDavis/notification-close-button

Browse source 
Swap notification close link for a button
This commit is contained in:
Hannah Wolfe 2014-08-05 20:39:04 +01:00
commit 102bb9d0c7
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/client/templates/components/gh-notification.hbs
View file

@ -2,5 +2,5 @@
<span class="notification-message"> <span class="notification-message">
{{{message.message}}} {{{message.message}}}
</span> </span>
<a class="close" {{action "closeNotification"}}><span class="hidden">Close</span></a> <button class="close" {{action "closeNotification"}}><span class="hidden">Close</span></button>
</section> </section>

4
core/test/functional/client/editor_test.js
View file

@ -283,7 +283,7 @@ CasperTest.begin('Post settings menu', 30, function suite(test) {
casper.waitForSelector('.notification-success', function waitForSuccess() { casper.waitForSelector('.notification-success', function waitForSuccess() {
test.assert(true, 'got success notification'); test.assert(true, 'got success notification');
test.assertSelectorHasText('.notification-success', 'Saved.'); test.assertSelectorHasText('.notification-success', 'Saved.');
casper.click('.notification-success a.close'); casper.click('.notification-success .close');
}, function onTimeout() { }, function onTimeout() {
test.assert(false, 'No success notification'); test.assert(false, 'No success notification');
}); });
@ -312,7 +312,7 @@ CasperTest.begin('Post settings menu', 30, function suite(test) {
casper.waitForSelector('.notification-success', function waitForSuccess() { casper.waitForSelector('.notification-success', function waitForSuccess() {
test.assert(true, 'got success notification'); test.assert(true, 'got success notification');
test.assertSelectorHasText('.notification-success', 'Permalink successfully changed to new-url-editor.'); test.assertSelectorHasText('.notification-success', 'Permalink successfully changed to new-url-editor.');
casper.click('.notification-success a.close'); casper.click('.notification-success .close');
}, function onTimeout() { }, function onTimeout() {
test.assert(false, 'No success notification'); test.assert(false, 'No success notification');
}); });