Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity

Cleaned up some unused code in test fixtures

Browse source 
- the themeService.loadAll method was refactored out ages ago, so this clearly isn't used in tests
- the rest are requires I spotted whilst working around the codebase
- note: we have noUnusedVars disabled as a linting error in tests because else should complains everywhere
This commit is contained in:
Hannah Wolfe 2021-04-26 12:35:01 +01:00
parent 9614d71e1f
commit 1025600ae1
3 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
test/utils/db-utils.js
View file

@ -6,7 +6,6 @@ const KnexMigrator = require('knex-migrator');
const knexMigrator = new KnexMigrator(); const knexMigrator = new KnexMigrator();
// Ghost Internals // Ghost Internals
const {events} = require('../../core/server/lib/common');
const config = require('../../core/shared/config'); const config = require('../../core/shared/config');
const db = require('../../core/server/data/db'); const db = require('../../core/server/data/db');
const schema = require('../../core/server/data/schema').tables; const schema = require('../../core/server/data/schema').tables;

4
test/utils/fixture-utils.js
View file

@ -15,7 +15,6 @@ const emailAnalyticsService = require('../../core/server/services/email-analytic
const permissions = require('../../core/server/services/permissions'); const permissions = require('../../core/server/services/permissions');
const settingsService = require('../../core/server/services/settings'); const settingsService = require('../../core/server/services/settings');
const settingsCache = require('../../core/server/services/settings/cache'); const settingsCache = require('../../core/server/services/settings/cache');
const themeService = require('../../core/frontend/services/themes');
// Other Test Utilities // Other Test Utilities
const context = require('./fixtures/context'); const context = require('./fixtures/context');
@ -595,9 +594,6 @@ const toDoList = {
invites: function insertInvites() { invites: function insertInvites() {
return fixtures.insertInvites(); return fixtures.insertInvites();
}, },
themes: function loadThemes() {
return themeService.loadAll();
},
webhooks: function insertWebhooks() { webhooks: function insertWebhooks() {
return fixtures.insertWebhooks(); return fixtures.insertWebhooks();
}, },

2
test/utils/index.js
View file

@ -14,10 +14,8 @@ const knexMigrator = new KnexMigrator();
// Ghost Internals // Ghost Internals
const config = require('../../core/shared/config'); const config = require('../../core/shared/config');
const boot = require('../../core/boot'); const boot = require('../../core/boot');
const {events} = require('../../core/server/lib/common');
const db = require('../../core/server/data/db'); const db = require('../../core/server/data/db');
const models = require('../../core/server/models'); const models = require('../../core/server/models');
const notify = require('../../core/server/notify');
const urlService = require('../../core/frontend/services/url'); const urlService = require('../../core/frontend/services/url');
const settingsService = require('../../core/server/services/settings'); const settingsService = require('../../core/server/services/settings');
const frontendSettingsService = require('../../core/frontend/services/settings'); const frontendSettingsService = require('../../core/frontend/services/settings');